Sign upLogin

rails/rails

View on GitHub
Star
actionpack/lib/action_dispatch/middleware/flash.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class FlashHash has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

    class FlashHash
      include Enumerable

      def self.from_session_value(value) # :nodoc:
        case value
Severity: Minor
Found in actionpack/lib/action_dispatch/middleware/flash.rb - About 2 hrs to fix

    Method commit_flash has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def commit_flash # :nodoc:
        return unless session.enabled?

        if flash_hash && (flash_hash.present? || session.key?("flash"))
          session["flash"] = flash_hash.to_session_value
    Severity: Minor
    Found in actionpack/lib/action_dispatch/middleware/flash.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status