Sign upLogin

rails/rails

View on GitHub
Star
actionview/lib/action_view/helpers/asset_url_helper.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method compute_asset_host has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

      def compute_asset_host(source = "", options = {})
        request = self.request if respond_to?(:request)
        host = options[:host]
        host ||= config.asset_host if defined? config.asset_host
Severity: Minor
Found in actionview/lib/action_view/helpers/asset_url_helper.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method asset_path has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def asset_path(source, options = {})
        raise ArgumentError, "nil is not a valid asset source" if source.nil?

        source = source.to_s
        return "" if source.blank?
Severity: Minor
Found in actionview/lib/action_view/helpers/asset_url_helper.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compute_asset_host has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def compute_asset_host(source = "", options = {})
        request = self.request if respond_to?(:request)
        host = options[:host]
        host ||= config.asset_host if defined? config.asset_host
Severity: Minor
Found in actionview/lib/action_view/helpers/asset_url_helper.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status