Sign upLogin

rails/rails

View on GitHub
Star
actionview/lib/action_view/lookup_context.rb

Summary

Maintainability
B
7 hrs
Test Coverage

Class LookupContext has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class LookupContext # :nodoc:
    attr_accessor :prefixes

    singleton_class.attr_accessor :registered_details
    self.registered_details = []
Severity: Minor
Found in actionview/lib/action_view/lookup_context.rb - About 2 hrs to fix

    Method formats= has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def formats=(values)
      if values
        values = values.dup
        values.concat(default_formats) if values.delete "*/*"
        values.uniq!
    Severity: Minor
    Found in actionview/lib/action_view/lookup_context.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exists? has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def exists?(name, prefixes = [], partial = false, keys = [], **options)
    Severity: Minor
    Found in actionview/lib/action_view/lookup_context.rb - About 35 mins to fix

      Method find has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def find(name, prefixes = [], partial = false, keys = [], options = {})
      Severity: Minor
      Found in actionview/lib/action_view/lookup_context.rb - About 35 mins to fix

        Method find_all has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def find_all(name, prefixes = [], partial = false, keys = [], options = {})
        Severity: Minor
        Found in actionview/lib/action_view/lookup_context.rb - About 35 mins to fix

          Method details_cache_key has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def self.details_cache_key(details)
        @details_keys.fetch(details) do
          if formats = details[:formats]
            unless Template::Types.valid_symbols?(formats)
              details = details.dup
          Severity: Minor
          Found in actionview/lib/action_view/lookup_context.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method normalize_name has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def normalize_name(name, prefixes)
        name = name.to_s
        idx = name.rindex("/")
        return name, prefixes.presence || [""] unless idx
          Severity: Minor
          Found in actionview/lib/action_view/lookup_context.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def find(name, prefixes = [], partial = false, keys = [], options = {})
        name, prefixes = normalize_name(name, prefixes)
        details, details_key = detail_args_for(options)
        @view_paths.find(name, prefixes, partial, details, details_key, keys)
          Severity: Minor
          Found in actionview/lib/action_view/lookup_context.rb and 1 other location - About 30 mins to fix
          actionview/lib/action_view/lookup_context.rb on lines 135..138

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def find_all(name, prefixes = [], partial = false, keys = [], options = {})
        name, prefixes = normalize_name(name, prefixes)
        details, details_key = detail_args_for(options)
        @view_paths.find_all(name, prefixes, partial, details, details_key, keys)
          Severity: Minor
          Found in actionview/lib/action_view/lookup_context.rb and 1 other location - About 30 mins to fix
          actionview/lib/action_view/lookup_context.rb on lines 128..131

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status