Sign upLogin

rails/rails

View on GitHub
Star
actionview/lib/action_view/render_parser/ripper_render_parser.rb

Summary

Maintainability
C
1 day
Test Coverage

Method parse_render_from_options has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

        def parse_render_from_options(options_hash)
          renders = []
          keys = options_hash.keys

          if (keys & RENDER_TYPE_KEYS).size < 1
Severity: Minor
Found in actionview/lib/action_view/render_parser/ripper_render_parser.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ripper_render_parser.rb has 266 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module ActionView
  module RenderParser
    class RipperRenderParser < Base # :nodoc:
      class Node < ::Array # :nodoc:
        attr_reader :type
Severity: Minor
Found in actionview/lib/action_view/render_parser/ripper_render_parser.rb - About 2 hrs to fix

    Method parse_render has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

            def parse_render(node)
          node = node.argument_nodes

          if (node.length == 1 || node.length == 2) && !node[0].hash?
            if node.length == 1
    Severity: Minor
    Found in actionview/lib/action_view/render_parser/ripper_render_parser.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse_render_from_options has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def parse_render_from_options(options_hash)
          renders = []
          keys = options_hash.keys

          if (keys & RENDER_TYPE_KEYS).size < 1
    Severity: Minor
    Found in actionview/lib/action_view/render_parser/ripper_render_parser.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                  return nil unless options_hash.key?(:partial)
      Severity: Major
      Found in actionview/lib/action_view/render_parser/ripper_render_parser.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return nil if options_hash.key?(:object) && options_hash.key?(:collection)
        Severity: Major
        Found in actionview/lib/action_view/render_parser/ripper_render_parser.rb - About 30 mins to fix

          Method argument_nodes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                  def argument_nodes
          raise unless fcall?
          return [] if self[1].nil?
          if self[1].last == false || self[1].last.type == :vcall
            self[1][0...-1]
          Severity: Minor
          Found in actionview/lib/action_view/render_parser/ripper_render_parser.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status