Sign upLogin

rails/rails

View on GitHub
Star
activerecord/lib/active_record/associations/association.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class Association has 43 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Association # :nodoc:
      attr_accessor :owner
      attr_reader :target, :reflection, :disable_joins

      delegate :options, to: :reflection
Severity: Minor
Found in activerecord/lib/active_record/associations/association.rb - About 5 hrs to fix

    Method load_target has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def load_target
        @target = find_target if (@stale_state && stale_target?) || find_target?

        loaded! unless loaded?
        target
    Severity: Minor
    Found in activerecord/lib/active_record/associations/association.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_target has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def find_target
          if violates_strict_loading?
            Base.strict_loading_violation!(owner: owner.class, reflection: reflection)
          end
    Severity: Minor
    Found in activerecord/lib/active_record/associations/association.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method raise_on_type_mismatch! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def raise_on_type_mismatch!(record)
          unless record.is_a?(reflection.klass)
            fresh_class = reflection.class_name.safe_constantize
            unless fresh_class && record.is_a?(fresh_class)
              message = "#{reflection.class_name}(##{reflection.klass.object_id}) expected, "\
    Severity: Minor
    Found in activerecord/lib/active_record/associations/association.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status