Sign upLogin

rails/rails

View on GitHub
Star
activerecord/lib/active_record/associations/builder/belongs_to.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method touch_record has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def self.touch_record(o, changes, foreign_key, name, touch) # :nodoc:
      old_foreign_id = changes[foreign_key] && changes[foreign_key].first

      if old_foreign_id
        association = o.association(name)
Severity: Minor
Found in activerecord/lib/active_record/associations/builder/belongs_to.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method touch_record has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.touch_record(o, changes, foreign_key, name, touch) # :nodoc:
      old_foreign_id = changes[foreign_key] && changes[foreign_key].first

      if old_foreign_id
        association = o.association(name)
Severity: Minor
Found in activerecord/lib/active_record/associations/builder/belongs_to.rb - About 1 hr to fix

    Method define_validations has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.define_validations(model, reflection)
      if reflection.options.key?(:required)
        reflection.options[:optional] = !reflection.options.delete(:required)
      end
    Severity: Minor
    Found in activerecord/lib/active_record/associations/builder/belongs_to.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method touch_record has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def self.touch_record(o, changes, foreign_key, name, touch) # :nodoc:
    Severity: Minor
    Found in activerecord/lib/active_record/associations/builder/belongs_to.rb - About 35 mins to fix

      Method add_touch_callbacks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.add_touch_callbacks(model, reflection)
      foreign_key = reflection.foreign_key
      name        = reflection.name
      touch       = reflection.options[:touch]
      Severity: Minor
      Found in activerecord/lib/active_record/associations/builder/belongs_to.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status