Sign upLogin

rails/rails

View on GitHub
Star
activerecord/lib/active_record/associations/has_many_through_association.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class HasManyThroughAssociation has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

    class HasManyThroughAssociation < HasManyAssociation # :nodoc:
      include ThroughAssociation

      def initialize(owner, reflection)
        super
Severity: Minor
Found in activerecord/lib/active_record/associations/has_many_through_association.rb - About 2 hrs to fix

    Method delete_records has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def delete_records(records, method)
          ensure_not_nested

          scope = through_association.scope
          scope.where! construct_join_attributes(*records)
    Severity: Minor
    Found in activerecord/lib/active_record/associations/has_many_through_association.rb - About 1 hr to fix

      Method delete_records has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

              def delete_records(records, method)
          ensure_not_nested

          scope = through_association.scope
          scope.where! construct_join_attributes(*records)
      Severity: Minor
      Found in activerecord/lib/active_record/associations/has_many_through_association.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status