Sign upLogin

rails/rails

View on GitHub
Star
activerecord/lib/active_record/associations/preloader/association.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class Association has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Association # :nodoc:
        class LoaderQuery
          attr_reader :scope, :association_key_name

          def initialize(scope, association_key_name)
Severity: Minor
Found in activerecord/lib/active_record/associations/preloader/association.rb - About 3 hrs to fix

    Method associate_records_from_unscoped has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

            def associate_records_from_unscoped(unscoped_records)
          return if unscoped_records.nil? || unscoped_records.empty?
          return if !reflection_scope.empty_scope?
          return if preload_scope && !preload_scope.empty_scope?
          return if reflection.collection?
    Severity: Minor
    Found in activerecord/lib/active_record/associations/preloader/association.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def initialize(klass, owners, reflection, preload_scope, reflection_scope, associate_by_default)
    Severity: Minor
    Found in activerecord/lib/active_record/associations/preloader/association.rb - About 45 mins to fix

      Method load_records has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def load_records(raw_records = nil)
          # owners can be duplicated when a relation has a collection association join
          # #compare_by_identity makes such owners different hash keys
          @records_by_owner = {}.compare_by_identity
          raw_records ||= loader_query.records_for([self])
      Severity: Minor
      Found in activerecord/lib/active_record/associations/preloader/association.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status