Sign upLogin

rails/rails

View on GitHub
Star
activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb

Summary

Maintainability
D
1 day
Test Coverage

File database_statements.rb has 386 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module ActiveRecord
  module ConnectionAdapters # :nodoc:
    module DatabaseStatements
      def initialize
        super
Severity: Minor
Found in activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb - About 5 hrs to fix

    Method to_sql_and_binds has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

          def to_sql_and_binds(arel_or_sql_string, binds = [], preparable = nil, allow_retry = false) # :nodoc:
        # Arel::TreeManager -> Arel::Node
        if arel_or_sql_string.respond_to?(:ast)
          arel_or_sql_string = arel_or_sql_string.ast
        end
    Severity: Minor
    Found in activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_fixture_sql has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

            def build_fixture_sql(fixtures, table_name)
          columns = schema_cache.columns_hash(table_name).reject { |_, column| supports_virtual_columns? && column.virtual? }

          values_list = fixtures.map do |fixture|
            fixture = fixture.stringify_keys
    Severity: Minor
    Found in activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_fixture_sql has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def build_fixture_sql(fixtures, table_name)
          columns = schema_cache.columns_hash(table_name).reject { |_, column| supports_virtual_columns? && column.virtual? }

          values_list = fixtures.map do |fixture|
            fixture = fixture.stringify_keys
    Severity: Minor
    Found in activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb - About 1 hr to fix

      Method to_sql_and_binds has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def to_sql_and_binds(arel_or_sql_string, binds = [], preparable = nil, allow_retry = false) # :nodoc:
        # Arel::TreeManager -> Arel::Node
        if arel_or_sql_string.respond_to?(:ast)
          arel_or_sql_string = arel_or_sql_string.ast
        end
      Severity: Minor
      Found in activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb - About 1 hr to fix

        Method select has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                def select(sql, name = nil, binds = [], prepare: false, async: false, allow_retry: false)
          if async && async_enabled?
            if current_transaction.joinable?
              raise AsynchronousQueryInsideTransactionError, "Asynchronous queries are not allowed inside transactions"
            end
        Severity: Minor
        Found in activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method sql_for_insert has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                def sql_for_insert(sql, pk, binds, returning) # :nodoc:
          if supports_insert_returning?
            if pk.nil?
              # Extract the table from the insert sql. Yuck.
              table_ref = extract_table_ref_from_insert_sql(sql)
        Severity: Minor
        Found in activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method insert has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def insert(arel, name = nil, pk = nil, id_value = nil, sequence_name = nil, binds = [], returning: nil)
        Severity: Minor
        Found in activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb - About 45 mins to fix

          Method transaction has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def transaction(requires_new: nil, isolation: nil, joinable: true, &block)
        if !requires_new && current_transaction.joinable?
          if isolation
            raise ActiveRecord::TransactionIsolationError, "cannot set isolation when joining a transaction"
          end
          Severity: Minor
          Found in activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method exec_insert has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def exec_insert(sql, name = nil, binds = [], pk = nil, sequence_name = nil, returning: nil)
          Severity: Minor
          Found in activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status