Sign upLogin

rails/rails

View on GitHub
Star
activerecord/lib/active_record/connection_adapters/abstract/transaction.rb

Summary

Maintainability
D
2 days
Test Coverage

File transaction.rb has 478 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module ActiveRecord
  module ConnectionAdapters
    # = Active Record Connection Adapters Transaction State
    class TransactionState
      def initialize(state = nil)
Severity: Minor
Found in activerecord/lib/active_record/connection_adapters/abstract/transaction.rb - About 7 hrs to fix

    Method within_new_transaction has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

          def within_new_transaction(isolation: nil, joinable: true)
        @connection.lock.synchronize do
          transaction = begin_transaction(isolation: isolation, joinable: joinable)
          begin
            yield transaction
    Severity: Minor
    Found in activerecord/lib/active_record/connection_adapters/abstract/transaction.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method prepare_instances_to_run_callbacks_on has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

            def prepare_instances_to_run_callbacks_on(records)
          records.each_with_object({}) do |record, candidates|
            next unless record.trigger_transactional_callbacks?

            earlier_saved_candidate = candidates[record]
    Severity: Minor
    Found in activerecord/lib/active_record/connection_adapters/abstract/transaction.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method begin_transaction has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def begin_transaction(isolation: nil, joinable: true, _lazy: true)
        @connection.lock.synchronize do
          run_commit_callbacks = !current_transaction.joinable?
          transaction =
            if @stack.empty?
    Severity: Minor
    Found in activerecord/lib/active_record/connection_adapters/abstract/transaction.rb - About 1 hr to fix

      Method before_commit_records has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def before_commit_records
        if @run_commit_callbacks
          if records
            if ActiveRecord.before_committed_on_all_records
              ite = unique_records
      Severity: Minor
      Found in activerecord/lib/active_record/connection_adapters/abstract/transaction.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method within_new_transaction has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def within_new_transaction(isolation: nil, joinable: true)
        @connection.lock.synchronize do
          transaction = begin_transaction(isolation: isolation, joinable: joinable)
          begin
            yield transaction
      Severity: Minor
      Found in activerecord/lib/active_record/connection_adapters/abstract/transaction.rb - About 1 hr to fix

        Method begin_transaction has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def begin_transaction(isolation: nil, joinable: true, _lazy: true)
        @connection.lock.synchronize do
          run_commit_callbacks = !current_transaction.joinable?
          transaction =
            if @stack.empty?
        Severity: Minor
        Found in activerecord/lib/active_record/connection_adapters/abstract/transaction.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method commit_records has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def commit_records
        if records
          begin
            ite = unique_records
        Severity: Minor
        Found in activerecord/lib/active_record/connection_adapters/abstract/transaction.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method materialize_transactions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def materialize_transactions
        return if @materializing_transactions

        if @has_unmaterialized_transactions
          @connection.lock.synchronize do
        Severity: Minor
        Found in activerecord/lib/active_record/connection_adapters/abstract/transaction.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status