Sign upLogin

rails/rails

View on GitHub
Star
activerecord/lib/active_record/connection_adapters/schema_cache.rb

Summary

Maintainability
C
1 day
Test Coverage

File schema_cache.rb has 380 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "active_support/core_ext/file/atomic"

module ActiveRecord
  module ConnectionAdapters
    class SchemaReflection
Severity: Minor
Found in activerecord/lib/active_record/connection_adapters/schema_cache.rb - About 5 hrs to fix

    Class SchemaCache has 27 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class SchemaCache
      def self._load_from(filename) # :nodoc:
        return unless File.file?(filename)

        read(filename) do |file|
    Severity: Minor
    Found in activerecord/lib/active_record/connection_adapters/schema_cache.rb - About 3 hrs to fix

      Method load_cache has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

              def load_cache(pool)
          # Can't load if schema dumps are disabled
          return unless possible_cache_available?

          # Check we can find one
      Severity: Minor
      Found in activerecord/lib/active_record/connection_adapters/schema_cache.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _load_from has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def self._load_from(filename) # :nodoc:
        return unless File.file?(filename)

        read(filename) do |file|
          if filename.include?(".dump")
      Severity: Minor
      Found in activerecord/lib/active_record/connection_adapters/schema_cache.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status