Sign upLogin

rails/rails

View on GitHub
Star
activerecord/lib/active_record/relation/batches.rb

Summary

Maintainability
C
1 day
Test Coverage

Method batch_on_unloaded_relation has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

      def batch_on_unloaded_relation(relation:, start:, finish:, load:, order:, use_ranges:, remaining:, batch_limit:)
        batch_orders = build_batch_orders(order)
        relation = relation.reorder(batch_orders.to_h).limit(batch_limit)
        relation = apply_limits(relation, start, finish, batch_orders)
        relation.skip_query_cache! # Retaining the results in the query cache would undermine the point of batching
Severity: Minor
Found in activerecord/lib/active_record/relation/batches.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method batch_on_unloaded_relation has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def batch_on_unloaded_relation(relation:, start:, finish:, load:, order:, use_ranges:, remaining:, batch_limit:)
        batch_orders = build_batch_orders(order)
        relation = relation.reorder(batch_orders.to_h).limit(batch_limit)
        relation = apply_limits(relation, start, finish, batch_orders)
        relation.skip_query_cache! # Retaining the results in the query cache would undermine the point of batching
Severity: Minor
Found in activerecord/lib/active_record/relation/batches.rb - About 1 hr to fix

    Method in_batches has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def in_batches(of: 1000, start: nil, finish: nil, load: false, error_on_ignore: nil, order: DEFAULT_ORDER, use_ranges: nil, &block)
      unless Array(order).all? { |ord| [:asc, :desc].include?(ord) }
        raise ArgumentError, ":order must be :asc or :desc or an array consisting of :asc or :desc, got #{order.inspect}"
      end
    Severity: Minor
    Found in activerecord/lib/active_record/relation/batches.rb - About 1 hr to fix

      Method in_batches has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def in_batches(of: 1000, start: nil, finish: nil, load: false, error_on_ignore: nil, order: DEFAULT_ORDER, use_ranges: nil, &block)
      unless Array(order).all? { |ord| [:asc, :desc].include?(ord) }
        raise ArgumentError, ":order must be :asc or :desc or an array consisting of :asc or :desc, got #{order.inspect}"
      end
      Severity: Minor
      Found in activerecord/lib/active_record/relation/batches.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status