Sign upLogin

rails/rails

View on GitHub
Star
activerecord/lib/active_record/relation/where_clause.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class WhereClause has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

    class WhereClause # :nodoc:
      delegate :any?, :empty?, to: :predicates

      def initialize(predicates)
        @predicates = predicates
Severity: Minor
Found in activerecord/lib/active_record/relation/where_clause.rb - About 3 hrs to fix

    Method or has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def or(other)
        left = self - other
        common = self - left
        right = other - common
    Severity: Minor
    Found in activerecord/lib/active_record/relation/where_clause.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method equalities has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def equalities(predicates, equality_only)
          equalities = []

          predicates.each do |node|
            if equality_only ? Arel::Nodes::Equality === node : equality_node?(node)
    Severity: Minor
    Found in activerecord/lib/active_record/relation/where_clause.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method each_attributes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def each_attributes
          predicates.each do |node|
            attr = extract_attribute(node) || begin
              node.left if equality_node?(node) && node.left.is_a?(Arel::Predications)
            end
    Severity: Minor
    Found in activerecord/lib/active_record/relation/where_clause.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status