Sign upLogin

rails/rails

View on GitHub
Star
activerecord/lib/active_record/tasks/postgresql_database_tasks.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method psql_env has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

        def psql_env
          {}.tap do |env|
            env["PGHOST"]         = db_config.host                        if db_config.host
            env["PGPORT"]         = configuration_hash[:port].to_s        if configuration_hash[:port]
            env["PGPASSWORD"]     = configuration_hash[:password].to_s    if configuration_hash[:password]
Severity: Minor
Found in activerecord/lib/active_record/tasks/postgresql_database_tasks.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method structure_dump has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def structure_dump(filename, extra_flags)
        search_path = \
          case ActiveRecord.dump_schemas
          when :schema_search_path
            configuration_hash[:schema_search_path]
Severity: Minor
Found in activerecord/lib/active_record/tasks/postgresql_database_tasks.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status