activestorage/lib/active_storage/service/gcs_service.rb
Class GCSService has 21 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class Service::GCSService < Service
class MetadataServerError < ActiveStorage::Error; end
class MetadataServerNotFoundError < ActiveStorage::Error; end
def initialize(public: false, **config)Method upload has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def upload(key, io, checksum: nil, content_type: nil, disposition: nil, filename: nil, custom_metadata: {})
instrument :upload, key: key, checksum: checksum do
# GCS's signed URLs don't include params such as response-content-type response-content_disposition
# in the signature, which means an attacker can modify them and bypass our effort to force these to
# binary and attachment when the file's content type requires it. The only way to force them is to- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"