activesupport/lib/active_support/cache.rb

Summary

Maintainability
F
4 days
Test Coverage

File cache.rb has 559 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "zlib"
require "active_support/core_ext/array/extract_options"
require "active_support/core_ext/enumerable"
require "active_support/core_ext/module/attribute_accessors"
require "active_support/core_ext/numeric/bytes"
Severity: Major
Found in activesupport/lib/active_support/cache.rb - About 1 day to fix

    Class Store has 44 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Store
          cattr_accessor :logger, instance_writer: true
          cattr_accessor :raise_on_invalid_cache_expiration_time, default: false
    
          attr_reader :silence, :options
    Severity: Minor
    Found in activesupport/lib/active_support/cache.rb - About 6 hrs to fix

      Method fetch has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
      Open

            def fetch(name, options = nil, &block)
              if block_given?
                options = merged_options(options)
                key = normalize_key(name, options)
      
      
      Severity: Minor
      Found in activesupport/lib/active_support/cache.rb - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
      Open

            def read(name, options = nil)
              options = merged_options(options)
              key     = normalize_key(name, options)
              version = normalize_version(name, options)
      
      
      Severity: Minor
      Found in activesupport/lib/active_support/cache.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method retrieve_pool_options has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

                def retrieve_pool_options(options)
                  if options.key?(:pool)
                    pool_options = options.delete(:pool)
                  elsif options.key?(:pool_size) || options.key?(:pool_timeout)
                    pool_options = {}
      Severity: Minor
      Found in activesupport/lib/active_support/cache.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method merged_options has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

              def merged_options(call_options)
                if call_options
                  call_options = normalize_options(call_options)
                  if call_options.key?(:expires_in) && call_options.key?(:expires_at)
                    raise ArgumentError, "Either :expires_in or :expires_at can be supplied, but not both"
      Severity: Minor
      Found in activesupport/lib/active_support/cache.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method retrieve_pool_options has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                def retrieve_pool_options(options)
                  if options.key?(:pool)
                    pool_options = options.delete(:pool)
                  elsif options.key?(:pool_size) || options.key?(:pool_timeout)
                    pool_options = {}
      Severity: Minor
      Found in activesupport/lib/active_support/cache.rb - About 1 hr to fix

        Method fetch has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def fetch(name, options = nil, &block)
                if block_given?
                  options = merged_options(options)
                  key = normalize_key(name, options)
        
        
        Severity: Minor
        Found in activesupport/lib/active_support/cache.rb - About 1 hr to fix

          Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

                def initialize(options = nil)
                  @options = options ? validate_options(normalize_options(options)) : {}
          
                  @options[:compress] = true unless @options.key?(:compress)
                  @options[:compress_threshold] ||= DEFAULT_COMPRESS_LIMIT
          Severity: Minor
          Found in activesupport/lib/active_support/cache.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method read has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def read(name, options = nil)
                  options = merged_options(options)
                  key     = normalize_key(name, options)
                  version = normalize_version(name, options)
          
          
          Severity: Minor
          Found in activesupport/lib/active_support/cache.rb - About 1 hr to fix

            Method _instrument has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                    def _instrument(operation, multi: false, options: nil, **payload, &block)
                      if logger && logger.debug? && !silence?
                        debug_key =
                          if multi
                            ": #{payload[:key].size} key(s) specified"
            Severity: Minor
            Found in activesupport/lib/active_support/cache.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method fetch_multi has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                  def fetch_multi(*names)
                    raise ArgumentError, "Missing block: `Cache#fetch_multi` requires a block." unless block_given?
                    return {} if names.empty?
            
                    options = names.extract_options!
            Severity: Minor
            Found in activesupport/lib/active_support/cache.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                              rescue DeserializationError
                                entry = nil
            Severity: Major
            Found in activesupport/lib/active_support/cache.rb - About 45 mins to fix

              Method read_multi_entries has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                      def read_multi_entries(names, **options)
                        names.each_with_object({}) do |name, results|
                          key   = normalize_key(name, options)
                          entry = read_entry(key, **options)
              
              
              Severity: Minor
              Found in activesupport/lib/active_support/cache.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method key_matcher has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                      def key_matcher(pattern, options) # :doc:
                        prefix = options[:namespace].is_a?(Proc) ? options[:namespace].call : options[:namespace]
                        if prefix
                          source = pattern.source
                          if source.start_with?("^")
              Severity: Minor
              Found in activesupport/lib/active_support/cache.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method expanded_key has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                      def expanded_key(key)
                        return key.cache_key.to_s if key.respond_to?(:cache_key)
              
                        case key
                        when Array
              Severity: Minor
              Found in activesupport/lib/active_support/cache.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status