Sign upLogin

railsadminteam/rails_admin

View on GitHub
Star
lib/rails_admin/extensions/paper_trail/auditing_adapter.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method listing_for_model_or_object has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def listing_for_model_or_object(model, object, query, sort, sort_reverse, all, page, per_page)
          sort =
            if sort.present?
              {COLUMN_MAPPING[sort.to_sym] => sort_reverse ? :desc : :asc}
            else
Severity: Minor
Found in lib/rails_admin/extensions/paper_trail/auditing_adapter.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method listing_for_object has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def listing_for_object(model, object, query, sort, sort_reverse, all, page, per_page = (RailsAdmin::Config.default_items_per_page || 20))
Severity: Major
Found in lib/rails_admin/extensions/paper_trail/auditing_adapter.rb - About 1 hr to fix

    Method listing_for_model_or_object has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def listing_for_model_or_object(model, object, query, sort, sort_reverse, all, page, per_page)
    Severity: Major
    Found in lib/rails_admin/extensions/paper_trail/auditing_adapter.rb - About 1 hr to fix

      Method listing_for_model has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def listing_for_model(model, query, sort, sort_reverse, all, page, per_page = (RailsAdmin::Config.default_items_per_page || 20))
      Severity: Major
      Found in lib/rails_admin/extensions/paper_trail/auditing_adapter.rb - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status