Sign upLogin

railsdog/spree_shipping_labels

View on GitHub
Star
app/helpers/spree/admin/shipping_label_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage

Assignment Branch Condition size for package_type_selector is too high. [18.28/15]
Open

  def package_type_selector shipment
    options = shipment.possible_package_types.collect do |package_type|
      [package_type.to_s, package_type.id]
    end
    return if options.empty?
Severity: Minor
Found in app/helpers/spree/admin/shipping_label_helper.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [11/10]
Open

  def package_type_selector shipment
    options = shipment.possible_package_types.collect do |package_type|
      [package_type.to_s, package_type.id]
    end
    return if options.empty?
Severity: Minor
Found in app/helpers/spree/admin/shipping_label_helper.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Extra empty line detected at module body end.
Open


end
Severity: Minor
Found in app/helpers/spree/admin/shipping_label_helper.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Extra empty line detected at module body beginning.
Open


  # A helper that outputs a `select` which will display the currently selected
Severity: Minor
Found in app/helpers/spree/admin/shipping_label_helper.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Align the parameters of a method call if they span more than one line.
Open

      id: nil, class: 'package-type-selector', data: {
        resource: admin_label_path(shipment_id: shipment.id),
        cost: shipment.label.try(:cost), order: shipment.order_id,
        shipment: shipment.id, insurance: (shipment.insurance_enabled? ? shipment.insurance : nil)
      }
Severity: Minor
Found in app/helpers/spree/admin/shipping_label_helper.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Missing top-level module documentation comment.
Open

module Spree::Admin::ShippingLabelHelper
Severity: Minor
Found in app/helpers/spree/admin/shipping_label_helper.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use nested module/class definitions instead of compact style.
Open

module Spree::Admin::ShippingLabelHelper
Severity: Minor
Found in app/helpers/spree/admin/shipping_label_helper.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Line is too long. [98/80]
Open

        shipment: shipment.id, insurance: (shipment.insurance_enabled? ? shipment.insurance : nil)
Severity: Minor
Found in app/helpers/spree/admin/shipping_label_helper.rb by rubocop

Use def with parentheses when there are parameters.
Open

  def package_type_selector shipment
Severity: Minor
Found in app/helpers/spree/admin/shipping_label_helper.rb by rubocop

This cops checks for parentheses around the arguments in method definitions. Both instance and class/singleton methods are checked.

Example: EnforcedStyle: require_parentheses (default)

# The `require_parentheses` style requires method definitions
# to always use parentheses

# bad
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

Example: EnforcedStyle: requirenoparentheses

# The `require_no_parentheses` style requires method definitions
# to never use parentheses

# bad
def bar(num1, num2)
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

Example: EnforcedStyle: requirenoparenthesesexceptmultiline

# The `require_no_parentheses_except_multiline` style prefers no
# parantheses when method definition arguments fit on single line,
# but prefers parantheses when arguments span multiple lines.

# bad
def bar(num1, num2)
  num1 + num2
end

def foo descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name
  do_something
end

# good
def bar num1, num2
  num1 + num2
end

def foo(descriptive_var_name,
        another_descriptive_var_name,
        last_descriptive_var_name)
  do_something
end

There are no issues that match your filters.

Category
Status