railslove/cmxl

View on GitHub

Showing 4 of 4 total issues

Class Transaction has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Transaction < Field
      self.tag = 61
      self.parser = %r{^(?<date>\d{6})(?<entry_date>\d{4})?(?<storno_flag>R?)(?<funds_code>[CD]{1})(?<currency_letter>[a-zA-Z])?(?<amount>\d{1,12},\d{0,2})(?<swift_code>(?:N|F).{3})(?<reference>NONREF|(.(?!\/\/)){,16}([^\/]){,1})((?:\/\/)(?<bank_reference>[^\n]{,16}))?((?:\n)(?<supplementary>.{,34}))?$}

      attr_accessor :details
Severity: Minor
Found in lib/cmxl/fields/transaction.rb - About 3 hrs to fix

    Class Statement has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Statement
        attr_accessor :source, :collection, :fields, :lines
    
        # Public: Initiate a new Statement and parse a provided single statement string
        # It directly parses the source and initiates file and transaction objects.
    Severity: Minor
    Found in lib/cmxl/statement.rb - About 2 hrs to fix

      Method parse! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def parse!
            self.fields = []
      
            lines = source.split(/(:[0-9A-Z]{2,3}:)/m).reject(&:empty?).each_slice(2).map(&:join)
      
      
      Severity: Minor
      Found in lib/cmxl/statement.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.parse(data, options = {})
          options[:statement_separator] ||= config[:statement_separator]
          # if no encoding is provided we try to guess using CharDet
          if options[:encoding].nil? && cd = CharDet.detect(data, silent: true)
            options[:encoding] = cd.encoding
      Severity: Minor
      Found in lib/cmxl.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language