Sign upLogin

railstack/go-on-rails

View on GitHub
Star

Showing 10 of 10 total issues

Method get_validation has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    def get_validation(validator, col)
        rules = []
        case validator.class.to_s
        when "ActiveRecord::Validations::PresenceValidator"
          rules << "required"
Severity: Minor
Found in lib/generators/gor/validator.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_schema_info has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    def get_schema_info
      info = {struct_body: "", has_assoc_dependent: false, assoc_info: {has_many: {}, has_one: {}, belongs_to: {}}}
      self.klass.reflect_on_all_associations.each do |assoc|
        tags = ["json:\"#{assoc.name.to_s},omitempty\" db:\"#{assoc.name.to_s}\" valid:\"-\""]
        case assoc.macro
Severity: Minor
Found in lib/generators/gor/association.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_schema_info has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    def get_schema_info
      struct_info = {
        col_names: [],
        timestamp_cols: [],
        has_datetime_type: false,
Severity: Minor
Found in lib/generators/gor/converter.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate_gor has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def generate_gor
    env_names = ActiveRecord::Base.configurations.keys
    rails_env = case env_name
                when "dev"
                  "development"
Severity: Major
Found in lib/generators/gor_generator.rb - About 2 hrs to fix

    Method generate_gor has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def generate_gor
    env_names = ActiveRecord::Base.configurations.keys
    rails_env = case env_name
                when "dev"
                  "development"
    Severity: Minor
    Found in lib/generators/gor_generator.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_schema_info has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def get_schema_info
      struct_info = {
        col_names: [],
        timestamp_cols: [],
        has_datetime_type: false,
    Severity: Minor
    Found in lib/generators/gor/converter.rb - About 1 hr to fix

      Method get_schema_info has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def get_schema_info
      info = {struct_body: "", has_assoc_dependent: false, assoc_info: {has_many: {}, has_one: {}, belongs_to: {}}}
      self.klass.reflect_on_all_associations.each do |assoc|
        tags = ["json:\"#{assoc.name.to_s},omitempty\" db:\"#{assoc.name.to_s}\" valid:\"-\""]
        case assoc.macro
      Severity: Minor
      Found in lib/generators/gor/association.rb - About 1 hr to fix

        Method get_validation has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def get_validation(validator, col)
        rules = []
        case validator.class.to_s
        when "ActiveRecord::Validations::PresenceValidator"
          rules << "required"
        Severity: Minor
        Found in lib/generators/gor/validator.rb - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                    unless assoc.options.empty?
            if assoc.options.key? :class_name
              class_name = assoc.options[:class_name]
            elsif assoc.options.key? :source
              class_name = assoc.options[:source].to_s.camelize
          Severity: Minor
          Found in lib/generators/gor/association.rb and 1 other location - About 15 mins to fix
          lib/generators/gor/association.rb on lines 17..22

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                    unless assoc.options.empty?
            if assoc.options.key? :class_name
              class_name = assoc.options[:class_name]
            elsif assoc.options.key? :source
              class_name = assoc.options[:source].to_s.camelize
          Severity: Minor
          Found in lib/generators/gor/association.rb and 1 other location - About 15 mins to fix
          lib/generators/gor/association.rb on lines 33..38

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language