Showing 81 of 82 total issues
Avoid too many return
statements within this method. Open
return $this->createDateTime($reflection);
Avoid too many return
statements within this method. Open
return (float)$value->getValue();
Avoid too many return
statements within this method. Open
return self::ERROR_MESSAGE_UTF8;
Avoid too many return
statements within this method. Open
return self::ERROR_MESSAGE_INF_OR_NAN;
Avoid too many return
statements within this method. Open
return self::ERROR_MESSAGE_UTF16;
Avoid too many return
statements within this method. Open
return "'";
Similar blocks of code found in 2 locations. Consider refactoring. Open
private function dataArgumentExtender(): \Closure
{
/** @var ArgumentDefinition|BaseArgument $argument */
return function (ArgumentDefinition $argument): void {
/** @var BaseArgument $this */
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 90.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid too many return
statements within this method. Open
return "\u{000C}";
Avoid too many return
statements within this method. Open
return \get_class($value);
Avoid too many return
statements within this method. Open
return Carbon::instance($value);
Avoid too many return
statements within this method. Open
return $this->toString($ast);
Function singular
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private function singular(iterable $routes, FieldResolve $event)
{
foreach ($routes as $route) {
$before = $this->fireDispatch($route, $event);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function buildInputFields
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private function buildInputFields(InputDefinition $input): array
{
$result = [];
foreach ($input->getArguments() as $field) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function preloadPaths
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private function preloadPaths(RepositoryInterface $config, CompilerInterface $compiler): void
{
[$paths, $extensions] = [
(array)$config->get(RepositoryInterface::KEY_PRELOAD_PATHS, []),
(array)$config->get(RepositoryInterface::KEY_PRELOAD_EXTENSIONS, []),
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function buildArguments
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private function buildArguments(HasArguments $arguments): array
{
$result = [];
foreach ($arguments->getArguments() as $argument) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function buildList
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private function buildList(NodeInterface $ast): bool
{
$this->isList = true;
foreach ($ast->getChildren() as $child) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function isUnionContainsInterface
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private function isUnionContainsInterface(UnionDefinition $union, TypeDefinition $object): bool
{
if ($object instanceof ObjectDefinition) {
foreach ($object->getInterfaces() as $interface) {
if ($union->hasType($interface->getName())) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function analyzeRequest
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private static function analyzeRequest(DocumentNode $ast, string $operation = null): array
{
/** @var OperationDefinitionNode $node */
foreach ($ast->definitions as $node) {
if ($node->kind === 'OperationDefinition') {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function iteratorToString
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private function iteratorToString($iterator, int $depth): string
{
$parts = [];
foreach ($iterator as $i => $item) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getSchema
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function getSchema(): ?SchemaDefinition
{
if ($this->schema === null) {
foreach ($this->types as $type) {
if ($type instanceof SchemaDefinition) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"