Sign upLogin

railt/sdl

View on GitHub
Star

Showing 7 of 7 total issues

Method createGrammarRules has 382 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function createGrammarRules(): array
    {
        return [
            new Concatenation(0, ['TypeSystemLanguage'], 'Document'),
            new Concatenation(1, ['ExecutableLanguage'], null),
Severity: Major
Found in src/GraphQL/BaseParser.php - About 1 day to fix

    File BaseParser.php has 588 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This file is part of Phplrt package.
 *
 * For the full copyright and license information, please view the LICENSE
    Severity: Major
    Found in src/GraphQL/BaseParser.php - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
      Severity: Major
      Found in src/GraphQL/AST/Definition/InterfaceNode.php and 1 other location - About 1 hr to fix
      src/GraphQL/AST/Definition/ObjectNode.php on lines 1..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
      Severity: Major
      Found in src/GraphQL/AST/Definition/ObjectNode.php and 1 other location - About 1 hr to fix
      src/GraphQL/AST/Definition/InterfaceNode.php on lines 1..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function runProxies has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function runProxies(array $children): iterable
    {
        $proxies = $this->traitConstructors(static::class, 'each');

        foreach ($children as $child) {
      Severity: Minor
      Found in src/GraphQL/AST/Node.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return (float)$value->getValue();
      Severity: Major
      Found in src/GraphQL/AST/Value/NumberValue.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->parseInt($value->getValue());
        Severity: Major
        Found in src/GraphQL/AST/Value/NumberValue.php - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language