Sign upLogin

rakuten-ws/rws-ruby-sdk

View on GitHub
Star

Showing 133 of 133 total issues

Line is too long. [85/80]
Open

    raise ArgumentError, 'Block is required to have one argument' if block.arity != 1
Severity: Minor
Found in lib/rakuten_web_service.rb by rubocop

Missing top-level class documentation comment.
Open

    class Genre < RakutenWebService::BaseGenre
Severity: Minor
Found in lib/rakuten_web_service/kobo/genre.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Align the parameters of a method call if they span more than one line.
Open

      :foodImageUrl, :mediumImageUrl, :smallImageUrl,
Severity: Minor
Found in lib/rakuten_web_service/recipe.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Line is too long. [89/80]
Open

      { application_id: application_id, affiliate_id: affiliate_id, format_version: '2' }
Severity: Minor
Found in lib/rakuten_web_service/configuration.rb by rubocop

Line is too long. [93/80]
Open

            Base.area_classes[children_class].new(child_data["#{children_class}Class"], self)
Severity: Minor
Found in lib/rakuten_web_service/travel/area_class.rb by rubocop

Line is too long. [120/80]
Open

                :courseName, :courseDistance, :longDrivingContest, :nearPin, :ratingNum, :evaluation, :staff, :facility,
Severity: Minor
Found in lib/rakuten_web_service/gora/course_detail.rb by rubocop

Missing top-level class documentation comment.
Open

      class Base < RakutenWebService::Travel::Resource
Severity: Minor
Found in lib/rakuten_web_service/travel/area_class.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Freeze mutable objects assigned to constants.
Open

  VERSION = '1.13.2'
Severity: Minor
Found in lib/rakuten_web_service/version.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Surrounding space missing in default value assignment.
Open

        def ranking(options={})
Severity: Minor
Found in lib/rakuten_web_service/ichiba/item.rb by rubocop

Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.

Example:

# bad
def some_method(arg1=:default, arg2=nil, arg3=[])
  # do something...
end

# good
def some_method(arg1 = :default, arg2 = nil, arg3 = [])
  # do something...
end

Line is too long. [113/80]
Open

        attribute :month, :planName, :planDate, :service, :price, :basePrice, :salesTax, :courseUseTax, :otherTax
Severity: Minor
Found in lib/rakuten_web_service/gora/course_detail.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

        :maxPrice, :salesMaxPrice, :usedExcludeMaxPrice, :usedExcludeSalesMaxPrice,
Severity: Minor
Found in lib/rakuten_web_service/ichiba/product.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Missing top-level class documentation comment.
Open

    class Item < Resource
Severity: Minor
Found in lib/rakuten_web_service/ichiba/item.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Align the parameters of a method call if they span more than one line.
Open

        :productCaption, :releaseDate,
Severity: Minor
Found in lib/rakuten_web_service/ichiba/product.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz
Severity
Category
Status
Source
Language