Cyclomatic complexity for find_resource_by_genre_id is too high. [8/6] Open
def self.find_resource_by_genre_id(genre_id) case genre_id when /^001/ then RWS::Books::Book when /^002/ then RWS::Books::CD when /^003/ then RWS::Books::DVD
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Missing top-level class documentation comment. Open
class Resource < RakutenWebService::Resource
This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.
The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.
# bad class Person # ... end # good # Description/Explanation of Person class class Person # ... end