Sign upLogin

rambler-digital-solutions/Generamba

View on GitHub
Star

Showing 840 of 840 total issues

Method has too many lines. [85/10]
Open

    def setup
      properties = {}

      setup_username_command = Generamba::CLI::SetupUsernameCommand.new
      setup_username_command.setup_username
Severity: Minor
Found in lib/generamba/cli/setup_command.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Class has too many lines. [133/100]
Open

  class XcodeprojHelper
    # Returns a PBXProject class for a given name
    # @param project_name [String] The name of the project file
    #
    # @return [Xcodeproj::Project]
Severity: Minor
Found in lib/generamba/helpers/xcodeproj_helper.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for setup is too high. [68.37/15]
Open

    def setup
      properties = {}

      setup_username_command = Generamba::CLI::SetupUsernameCommand.new
      setup_username_command.setup_username
Severity: Minor
Found in lib/generamba/cli/setup_command.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for initialize is too high. [66.9/15]
Open

    def initialize(name, rambafile, options)
      # Base initialization
      @name = name
      @description = options[:description] ? options[:description] : "#{name} module"
      @author = rambafile[AUTHOR_NAME_KEY] ? rambafile[AUTHOR_NAME_KEY] : UserPreferences.obtain_username
Severity: Minor
Found in lib/generamba/code_generation/code_module.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for generate_module is too high. [59.21/15]
Open

        def generate_module(name, code_module, template)
            # Setting up Xcode objects
            project = XcodeprojHelper.obtain_project(code_module.xcodeproj_path)

            # Configuring file paths
Severity: Minor
Found in lib/generamba/module_generator.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method setup has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    def setup
      properties = {}

      setup_username_command = Generamba::CLI::SetupUsernameCommand.new
      setup_username_command.setup_username
Severity: Minor
Found in lib/generamba/cli/setup_command.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has too many lines. [38/10]
Open

        def generate_module(name, code_module, template)
            # Setting up Xcode objects
            project = XcodeprojHelper.obtain_project(code_module.xcodeproj_path)

            # Configuring file paths
Severity: Minor
Found in lib/generamba/module_generator.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [37/10]
Open

        def process_files_if_needed(files, code_module, template, project, targets, group_path, dir_path, root_path, processed_groups = [])
            # It's possible that current project doesn't test targets configured, so it doesn't need to generate tests.
            # The same is for files property - a template can have only test or project files
            if targets.count == 0 || files == nil || files.count == 0 || dir_path == nil || group_path == nil
                return
Severity: Minor
Found in lib/generamba/module_generator.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [35/10]
Open

    def install_template(template_declaration)
      template_name = template_declaration.name
      puts("Installing #{template_name}...")

      template_name = template_declaration.name
Severity: Minor
Found in lib/generamba/template/installer/catalog_installer.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for install_template is too high. [39.42/15]
Open

    def install_template(template_declaration)
      template_name = template_declaration.name
      puts("Installing #{template_name}...")

      template_name = template_declaration.name
Severity: Minor
Found in lib/generamba/template/installer/catalog_installer.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for process_files_if_needed is too high. [39.22/15]
Open

        def process_files_if_needed(files, code_module, template, project, targets, group_path, dir_path, root_path, processed_groups = [])
            # It's possible that current project doesn't test targets configured, so it doesn't need to generate tests.
            # The same is for files property - a template can have only test or project files
            if targets.count == 0 || files == nil || files.count == 0 || dir_path == nil || group_path == nil
                return
Severity: Minor
Found in lib/generamba/module_generator.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [32/10]
Open

    def gen(module_name, template_name)
      does_rambafile_exist = Dir[RAMBAFILE_NAME].count > 0

      unless does_rambafile_exist
        puts('Rambafile not found! Run `generamba setup` in the working directory instead!'.red)
Severity: Minor
Found in lib/generamba/cli/gen_command.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [31/10]
Open

    def initialize(name, rambafile, options)
      # Base initialization
      @name = name
      @description = options[:description] ? options[:description] : "#{name} module"
      @author = rambafile[AUTHOR_NAME_KEY] ? rambafile[AUTHOR_NAME_KEY] : UserPreferences.obtain_username
Severity: Minor
Found in lib/generamba/code_generation/code_module.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for gen is too high. [35.59/15]
Open

    def gen(module_name, template_name)
      does_rambafile_exist = Dir[RAMBAFILE_NAME].count > 0

      unless does_rambafile_exist
        puts('Rambafile not found! Run `generamba setup` in the working directory instead!'.red)
Severity: Minor
Found in lib/generamba/cli/gen_command.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [28/10]
Open

    def install_template(template_declaration)
      template_name = template_declaration.name
      puts("Installing #{template_name}...")

      repo_url = template_declaration.git
Severity: Minor
Found in lib/generamba/template/installer/remote_installer.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Perceived complexity for setup is too high. [24/7]
Open

    def setup
      properties = {}

      setup_username_command = Generamba::CLI::SetupUsernameCommand.new
      setup_username_command.setup_username
Severity: Minor
Found in lib/generamba/cli/setup_command.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Cyclomatic complexity for setup is too high. [22/6]
Open

    def setup
      properties = {}

      setup_username_command = Generamba::CLI::SetupUsernameCommand.new
      setup_username_command.setup_username
Severity: Minor
Found in lib/generamba/cli/setup_command.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method setup has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def setup
      properties = {}

      setup_username_command = Generamba::CLI::SetupUsernameCommand.new
      setup_username_command.setup_username
Severity: Major
Found in lib/generamba/cli/setup_command.rb - About 3 hrs to fix

    Method retrieve_group_or_create_if_needed has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.retrieve_group_or_create_if_needed(group_path, dir_path, file_group_path, project, create_group_if_not_exists, group_is_logical = false)
      group_names = path_names_from_path(group_path)
      group_components_count = group_names.count
      group_names += path_names_from_path(file_group_path) if file_group_path
    Severity: Minor
    Found in lib/generamba/helpers/xcodeproj_helper.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Assignment Branch Condition size for install_template is too high. [28.39/15]
    Open

        def install_template(template_declaration)
      template_name = template_declaration.name
      puts("Installing #{template_name}...")

      repo_url = template_declaration.git
    Severity: Minor
    Found in lib/generamba/template/installer/remote_installer.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Severity
    Category
    Status
    Source
    Language