ramitos/react-json-stream

View on GitHub

Showing 10 of 10 total issues

Function _updateComponent has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _updateComponent(transaction, prev, next, context) {
    const getContent = function(children) {
      return includes(CONTENT_TYPES, typeof children) ? children : null;
    };

Severity: Major
Found in src/json-component.js - About 2 hrs to fix

    Function _updateComponent has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      _updateComponent(transaction, prev, next, context) {
        const getContent = function(children) {
          return includes(CONTENT_TYPES, typeof children) ? children : null;
        };
    
    
    Severity: Minor
    Found in src/json-component.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Parsing error: The keyword 'const' is reserved
    Open

    const ReactUpdates = require('react/lib/ReactUpdates');
    Severity: Minor
    Found in src/json-mount.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Parsing error: The keyword 'const' is reserved
    Open

    const ReactVersion = require('react/lib/ReactVersion');
    Severity: Minor
    Found in src/react-json-stream.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Parsing error: The keyword 'const' is reserved
    Open

    const JSONIDOperations = require('./json-id-operations');
    Severity: Minor
    Found in src/json-component-environment.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Parsing error: The keyword 'const' is reserved
    Open

    const ReactInjection = require('react/lib/ReactInjection');
    Severity: Minor
    Found in src/json-inject.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Parsing error: The keyword 'const' is reserved
    Open

    const CallbackQueue = require('react/lib/CallbackQueue');
    Severity: Minor
    Found in src/json-reconcile-transaction.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Parsing error: The keyword 'const' is reserved
    Open

    const escapeTextContentForBrowser = require('react/lib/escapeTextContentForBrowser');
    Severity: Minor
    Found in src/json-text-component.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Expected to return a value at the end of function.
    Open

    var TreeStream = module.exports = function() {
    Severity: Minor
    Found in src/tree-stream.js by eslint

    require return statements to either always or never specify values (consistent-return)

    Unlike statically-typed languages which enforce that a function returns a specified type of value, JavaScript allows different code paths in a function to return different types of values.

    A confusing aspect of JavaScript is that a function returns undefined if any of the following are true:

    • it does not execute a return statement before it exits
    • it executes return which does not specify a value explicitly
    • it executes return undefined
    • it executes return void followed by an expression (for example, a function call)
    • it executes return followed by any other expression which evaluates to undefined

    If any code paths in a function return a value explicitly but some code path do not return a value explicitly, it might be a typing mistake, especially in a large function. In the following example:

    • a code path through the function returns a Boolean value true
    • another code path does not return a value explicitly, therefore returns undefined implicitly
    function doSomething(condition) {
        if (condition) {
            return true;
        } else {
            return;
        }
    }

    Rule Details

    This rule requires return statements to either always or never specify values. This rule ignores function definitions where the name begins with an uppercase letter, because constructors (when invoked with the new operator) return the instantiated object implicitly if they do not return another object explicitly.

    Examples of incorrect code for this rule:

    /*eslint consistent-return: "error"*/
    
    function doSomething(condition) {
        if (condition) {
            return true;
        } else {
            return;
        }
    }
    
    function doSomething(condition) {
        if (condition) {
            return true;
        }
    }

    Examples of correct code for this rule:

    /*eslint consistent-return: "error"*/
    
    function doSomething(condition) {
        if (condition) {
            return true;
        } else {
            return false;
        }
    }
    
    function Foo() {
        if (!(this instanceof Foo)) {
            return new Foo();
        }
    
        this.a = 0;
    }

    Options

    This rule has an object option:

    • "treatUndefinedAsUnspecified": false (default) always either specify values or return undefined implicitly only.
    • "treatUndefinedAsUnspecified": true always either specify values or return undefined explicitly or implicitly.

    treatUndefinedAsUnspecified

    Examples of incorrect code for this rule with the default { "treatUndefinedAsUnspecified": false } option:

    /*eslint consistent-return: ["error", { "treatUndefinedAsUnspecified": false }]*/
    
    function foo(callback) {
        if (callback) {
            return void callback();
        }
        // no return statement
    }
    
    function bar(condition) {
        if (condition) {
            return undefined;
        }
        // no return statement
    }

    Examples of incorrect code for this rule with the { "treatUndefinedAsUnspecified": true } option:

    /*eslint consistent-return: ["error", { "treatUndefinedAsUnspecified": true }]*/
    
    function foo(callback) {
        if (callback) {
            return void callback();
        }
        return true;
    }
    
    function bar(condition) {
        if (condition) {
            return undefined;
        }
        return true;
    }

    Examples of correct code for this rule with the { "treatUndefinedAsUnspecified": true } option:

    /*eslint consistent-return: ["error", { "treatUndefinedAsUnspecified": true }]*/
    
    function foo(callback) {
        if (callback) {
            return void callback();
        }
        // no return statement
    }
    
    function bar(condition) {
        if (condition) {
            return undefined;
        }
        // no return statement
    }

    When Not To Use It

    If you want to allow functions to have different return behavior depending on code branching, then it is safe to disable this rule. Source: http://eslint.org/docs/rules/

    Parsing error: The keyword 'const' is reserved
    Open

    const ReactMultiChild = require('react/lib/ReactMultiChild');
    Severity: Minor
    Found in src/json-component.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Severity
    Category
    Status
    Source
    Language