Sign upLogin

rangoo94/bestest

View on GitHub
Star

Showing 29 of 58 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

abstract class CompilerAdapter<OptionsType = Record<string, any>> implements CompilerAdapterInterface {
  readonly options: OptionsType
  abstract readonly type: string
  abstract readonly name: string
Severity: Major
Found in packages/compiler/lib/CompilerAdapter.ts and 1 other location - About 7 hrs to fix
packages/runner/lib/RunnerAdapter.ts on lines 13..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 187.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

abstract class RunnerAdapter<OptionsType = Record<string, any>> implements RunnerAdapterInterface {
  readonly options: OptionsType
  abstract readonly type: string
  abstract readonly name: string
Severity: Major
Found in packages/runner/lib/RunnerAdapter.ts and 1 other location - About 7 hrs to fix
packages/compiler/lib/CompilerAdapter.ts on lines 13..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 187.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  initialize (callback: (error: any | null) => any): void {
    // Delay functions, to ensure that their errors will not affect the flow
    const emit = createDelayedFunction(this.events.emit.bind(this.events))
    const call = createDelayedFunction(callback)
Severity: Major
Found in packages/runner/lib/Runner.ts and 1 other location - About 6 hrs to fix
packages/compiler/lib/Compiler.ts on lines 89..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  initialize (callback: (error: any | null) => any) {
    // Delay functions, to ensure that their errors will not affect the flow
    const emit = createDelayedFunction(this.events.emit.bind(this.events))
    const call = createDelayedFunction(callback)
Severity: Major
Found in packages/compiler/lib/Compiler.ts and 1 other location - About 6 hrs to fix
packages/runner/lib/Runner.ts on lines 74..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function resolveFilePath has a Cognitive Complexity of 20 (exceeds 7 allowed). Consider refactoring.
Open

function resolveFilePath (
  filePath: string,
  parentModule: Module,
  extensions: string[] = acceptedScriptExtensions,
  fileSystem: FsInterface = fs,
Severity: Minor
Found in packages/node-module-sandbox/lib/resolveFilePath.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    options.files = options.files.map(filePath => {
      if (!path.isAbsolute(filePath)) {
        // @ts-ignore
        return path.resolve(path.join(options.rootDirectory, filePath))
      }
Severity: Major
Found in packages/compiler/lib/Compiler.ts and 1 other location - About 1 hr to fix
packages/compiler/lib/Compiler.ts on lines 263..270

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    options.entries = options.entries.map(filePath => {
      if (!path.isAbsolute(filePath)) {
        // @ts-ignore
        return path.resolve(path.join(options.rootDirectory, filePath))
      }
Severity: Major
Found in packages/compiler/lib/Compiler.ts and 1 other location - About 1 hr to fix
packages/compiler/lib/Compiler.ts on lines 231..238

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function compile has 45 lines of code (exceeds 30 allowed). Consider refactoring.
Open

  compile (options: CompilerAdapterCompileOptionsInterface, callback: CompilerCallbackType): void {
    // Retrieve 'webpack' package
    const webpack = require('webpack')

    // Build Webpack configuration
Severity: Minor
Found in packages/compiler-webpack/lib/WebpackCompilerAdapter.ts - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (!Array.isArray(options.files) || options.files.filter(x => typeof x !== 'string').length > 0) {
      throw new Error('Invalid files passed for Compiler.compile.')
    }
    Severity: Major
    Found in packages/compiler/lib/Compiler.ts and 1 other location - About 1 hr to fix
    packages/compiler/lib/Compiler.ts on lines 258..260

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (!Array.isArray(options.entries) || options.entries.filter(x => typeof x !== 'string').length > 0) {
      throw new Error('Invalid entries passed for Compiler.compile.')
    }
    Severity: Major
    Found in packages/compiler/lib/Compiler.ts and 1 other location - About 1 hr to fix
    packages/compiler/lib/Compiler.ts on lines 226..228

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _buildCompilationOptions has 41 lines of code (exceeds 30 allowed). Consider refactoring.
    Open

      private _buildCompilationOptions (options?: Partial<CompilerCompileOptionsInterface>): CompilerCompileOptionsInterface {
    // Copy passed options
    options = assign({}, options || {})

    // Set-up root directory
    Severity: Minor
    Found in packages/compiler/lib/Compiler.ts - About 1 hr to fix

      Function _buildCompilationOptions has a Cognitive Complexity of 14 (exceeds 7 allowed). Consider refactoring.
      Open

        private _buildCompilationOptions (options?: Partial<CompilerCompileOptionsInterface>): CompilerCompileOptionsInterface {
    // Copy passed options
    options = assign({}, options || {})

    // Set-up root directory
      Severity: Minor
      Found in packages/compiler/lib/Compiler.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function compile has 33 lines of code (exceeds 30 allowed). Consider refactoring.
      Open

        compile (options: Partial<CompilerCompileOptionsInterface>, callback: CompilerCallbackType) {
    // Delay functions, to ensure that their errors will not affect the flow
    const emit = createDelayedFunction(this.events.emit.bind(this.events))
    const call = createDelayedFunction(callback)
      Severity: Minor
      Found in packages/compiler/lib/Compiler.ts - About 1 hr to fix

        Function getNodejsEnvironmentDetails has a Cognitive Complexity of 12 (exceeds 7 allowed). Consider refactoring.
        Open

        function getNodejsEnvironmentDetails (): NodejsEnvironmentDetailsInterface {
  const os = getOsPackage()
  const process = getProcessObject()

  const version = typeof process.version === 'string'
        Severity: Minor
        Found in packages/detect-environment/lib/getNodejsEnvironmentDetails.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createNativeEquivalent has a Cognitive Complexity of 10 (exceeds 7 allowed). Consider refactoring.
        Open

          createNativeEquivalent (): object {
    const fsCopy = this.clone().fs

    // Copy all native FS properties
    for (const key in fs) {
        Severity: Minor
        Found in packages/fs/lib/FileSystem.ts - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function resolveFilePath has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          filePath: string,
  parentModule: Module,
  extensions: string[] = acceptedScriptExtensions,
  fileSystem: FsInterface = fs,
  allowNoExtension: boolean = true
        Severity: Minor
        Found in packages/node-module-sandbox/lib/resolveFilePath.ts - About 35 mins to fix

          Avoid too many return statements within this function.
          Open

            return null
          Severity: Major
          Found in packages/node-module-sandbox/lib/resolveFilePath.ts - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                this.options = buildOptions(
      options || {},
      (this.constructor as typeof NodeModuleSandbox).defaultOptions
    ) as NodeModuleSandboxOptionsInterface
            Severity: Minor
            Found in packages/node-module-sandbox/lib/NodeModuleSandbox.ts and 1 other location - About 30 mins to fix
            packages/fs/lib/FileSystem.ts on lines 37..40

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                this.options = buildOptions(
      options || {},
      (this.constructor as typeof FileSystem).defaultOptions
    ) as FileSystemOptionsInterface
            Severity: Minor
            Found in packages/fs/lib/FileSystem.ts and 1 other location - About 30 mins to fix
            packages/node-module-sandbox/lib/NodeModuleSandbox.ts on lines 34..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                return (picoseconds / 1e3).toFixed(fractionDigits) + 'ns'
            Severity: Major
            Found in packages/math/lib/formatDuration.ts - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language