Sign upLogin

raphaeleidus/grunt-lazyload

View on GitHub
Star

Showing 7 of 7 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    grunt.registerTask = (...args) => {
      // If lazy load is registering grunt tasks and it matches the directory, filename, and
      // task name of a known alias, replace the task name with the alias name.
      if (this.loadingFile) {
        const key = `${this.loadingFile.directory}:${this.loadingFile.filename}:${args[0]}`;
Severity: Major
Found in lib/grunt-lazyload.js and 1 other location - About 4 hrs to fix
lib/grunt-lazyload.js on lines 62..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    grunt.registerMultiTask = (...args) => {
      // If lazy load is registering grunt tasks and it matches the directory, filename, and
      // task name of a known alias, replace the task name with the alias name.
      if (this.loadingFile) {
        const key = `${this.loadingFile.directory}:${this.loadingFile.filename}:${args[0]}`;
Severity: Major
Found in lib/grunt-lazyload.js and 1 other location - About 4 hrs to fix
lib/grunt-lazyload.js on lines 47..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function constructor has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  constructor(grunt) {
    // Instance of grunt this lazy loader is installed under
    this.grunt = grunt;

    // Keep track of all tasks that can be lazy-loaded, and what directory/filename
Severity: Minor
Found in lib/grunt-lazyload.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function constructor has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(grunt) {
    // Instance of grunt this lazy loader is installed under
    this.grunt = grunt;

    // Keep track of all tasks that can be lazy-loaded, and what directory/filename
Severity: Minor
Found in lib/grunt-lazyload.js - About 1 hr to fix

    Function exports has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(grunt) {

  // Project configuration.
  grunt.initConfig({
    jshint: {
    Severity: Minor
    Found in Gruntfile.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (this.grunt.option('help') || this.grunt.option('h')) {
      return this.grunt.loadTasks(tasksdir);
    }
      Severity: Minor
      Found in lib/grunt-lazyload.js and 1 other location - About 50 mins to fix
      lib/grunt-lazyload.js on lines 103..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (this.grunt.option('help') || this.grunt.option('h')) {
      return this.grunt.loadNpmTasks(modulename);
    }
      Severity: Minor
      Found in lib/grunt-lazyload.js and 1 other location - About 50 mins to fix
      lib/grunt-lazyload.js on lines 81..83

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language