Sign upLogin

rapid7/metasploit-aggregator

View on GitHub
Star
ruby/lib/metasploit/aggregator.rb

Summary

Maintainability
C
1 day
Test Coverage

File aggregator.rb has 421 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'socket'
require 'openssl'
require 'thread'
require 'securerandom'
Severity: Minor
Found in ruby/lib/metasploit/aggregator.rb - About 6 hrs to fix

    Method process has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

          def process(responses)
        requests = EnumeratorQueue.new(self)
        uuid = nil

        requestingThread = Thread.new do
    Severity: Minor
    Found in ruby/lib/metasploit/aggregator.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def process(responses)
        requests = EnumeratorQueue.new(self)
        uuid = nil

        requestingThread = Thread.new do
    Severity: Minor
    Found in ruby/lib/metasploit/aggregator.rb - About 1 hr to fix

      Method each_item has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def each_item
        return enum_for(:each_item) unless block_given?
        loop do
          r = @q.pop
          break if r.equal?(@sentinel)
      Severity: Minor
      Found in ruby/lib/metasploit/aggregator.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status