Sign upLogin

rapid7/metasploit-aggregator

View on GitHub
Star
ruby/lib/metasploit/aggregator/router.rb

Summary

Maintainability
A
45 mins
Test Coverage

Method reverse_route has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def reverse_route(uuid)
        # this method is not ready for prime time yet as will not
        # support multiple sessions properly, either need unique Queue
        # for each session which can be identified on reverse or need
        # pipeline request order to ensure all results are posted in order only
Severity: Minor
Found in ruby/lib/metasploit/aggregator/router.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status