Sign upLogin

rapid7/metasploit-aggregator

View on GitHub
Star
ruby/lib/metasploit/aggregator/session_detail_service.rb

Summary

Maintainability
C
1 day
Test Coverage

Method process_tlv has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

      def process_tlv
        while true
          begin
            request, payload = @tlv_queue.pop
            if request.body && request.body.length > 0
Severity: Minor
Found in ruby/lib/metasploit/aggregator/session_detail_service.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_tlv has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def process_tlv
        while true
          begin
            request, payload = @tlv_queue.pop
            if request.body && request.body.length > 0
Severity: Minor
Found in ruby/lib/metasploit/aggregator/session_detail_service.rb - About 1 hr to fix

    Method eval_tlv_enc has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def eval_tlv_enc(request)
        # this is really expensive as we have to process every
        # piece of information presented from the console to eval for enc requests
        response = nil
        begin
    Severity: Minor
    Found in ruby/lib/metasploit/aggregator/session_detail_service.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status