Sign upLogin

rapid7/metasploit-credential

View on GitHub
Star

Showing 29 of 29 total issues

Method create_credential has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create_credential(opts={})
    return nil unless active_db?

    if self.respond_to?(:[]) and self[:task]
      opts[:task_id] ||= self[:task].record.id
Severity: Minor
Found in lib/metasploit/credential/creation.rb - About 1 hr to fix

    Method import_short_form has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def import_short_form
    core_opts = []
    all_creds_valid = true
    Metasploit::Credential::Core.transaction do
      csv_object.each do |row|
    Severity: Minor
    Found in lib/metasploit/credential/importer/core.rb - About 1 hr to fix

      Method convert_creds_in_workspace has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def convert_creds_in_workspace(workspace)
    workspace.creds.each do |cred|
      service = cred.service
      begin
        core = create_credential(
      Severity: Minor
      Found in lib/metasploit/credential/migrator.rb - About 1 hr to fix

        Method create_credential_core has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def create_credential_core(opts={})
    return nil unless active_db?

    if self.respond_to?(:[]) and self[:task]
      opts[:task_id] ||= self[:task].record.id
        Severity: Minor
        Found in lib/metasploit/credential/creation.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method invalidate_login has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def invalidate_login(opts = {})
    return nil unless active_db?
    address     = opts.fetch(:address)
    return nil unless Rex::Socket.is_ipv4?(address) || Rex::Socket.is_ipv6?(address)
    port        = opts.fetch(:port)
        Severity: Minor
        Found in lib/metasploit/credential/creation.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method maximal_clusters has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.maximal_clusters
    clusters = cluster_by_class.values
    unique_clusters = clusters.uniq

    maximal_clusters = unique_clusters.dup
        Severity: Minor
        Found in lib/metasploit/credential/entity_relationship_diagram.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method public_for_ssh_key has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def public_for_ssh_key
      if private.present? && private.type == Metasploit::Credential::SSHKey.name
        errors.add(:base, :public_for_ssh_key) unless public.present?
      end
    end
        Severity: Minor
        Found in lib/metasploit/credential/core_validations.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          scope :origin_service_host_id, lambda { |host_id|
    core_table = Metasploit::Credential::Core.arel_table
    host_table = Mdm::Host.arel_table
    services_hosts.select(core_table[:id]).where(host_table[:id].eq(host_id))
        Severity: Minor
        Found in app/models/metasploit/credential/core.rb and 1 other location - About 15 mins to fix
        app/models/metasploit/credential/core.rb on lines 162..165

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          scope :origin_session_host_id, lambda { |host_id|
    core_table = Metasploit::Credential::Core.arel_table
    host_table = Mdm::Host.arel_table
    sessions_hosts.select(core_table[:id]).where(host_table[:id].eq(host_id))
        Severity: Minor
        Found in app/models/metasploit/credential/core.rb and 1 other location - About 15 mins to fix
        app/models/metasploit/credential/core.rb on lines 150..153

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language