Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
app/concerns/mdm/workspace/boundary_range.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method allow_actions_on? has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def allow_actions_on?(ips)
      return true unless limit_to_network
      return true unless boundary
      return true if boundary.empty?
      boundaries = Shellwords.split(boundary)
Severity: Minor
Found in app/concerns/mdm/workspace/boundary_range.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method boundary_must_be_ip_range has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def boundary_must_be_ip_range
      unless boundary.blank?
        begin
          boundaries = Shellwords.split(boundary)
        rescue ArgumentError
Severity: Minor
Found in app/concerns/mdm/workspace/boundary_range.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return false unless given_range # Can't do things to nonexistant IPs
Severity: Major
Found in app/concerns/mdm/workspace/boundary_range.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return allowed
    Severity: Major
    Found in app/concerns/mdm/workspace/boundary_range.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status