Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
external/source/shellcode/windows/x86/build.py

Summary

Maintainability
F
4 days
Test Coverage

Function main has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
Open

def main(argv=None):
    if not argv:
        argv = sys.argv
        if len(argv) == 1:
            print('Usage: build.py [clean|all|<name>]')
Severity: Minor
Found in external/source/shellcode/windows/x86/build.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    for name in files:
                        build(name[:-4])
            else:
Severity: Major
Found in external/source/shellcode/windows/x86/build.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        for name in files:
                        build(name[:-4])
                for root, dirs, files in os.walk('./src/kernel/'):
    Severity: Major
    Found in external/source/shellcode/windows/x86/build.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          for name in files:
                        build(name[:-4])
                for root, dirs, files in os.walk('./src/single/'):
      Severity: Major
      Found in external/source/shellcode/windows/x86/build.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            for name in files:
                        build(name[:-4])
                for root, dirs, files in os.walk('./src/migrate/'):
        Severity: Major
        Found in external/source/shellcode/windows/x86/build.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              for name in files:
                        build(name[:-4])
                for root, dirs, files in os.walk('./src/stage/'):
          Severity: Major
          Found in external/source/shellcode/windows/x86/build.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                for name in files:
                        build(name[:-4])
                for root, dirs, files in os.walk('./src/stager/'):
            Severity: Major
            Found in external/source/shellcode/windows/x86/build.py - About 45 mins to fix

              Function clean has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def clean(dir='./bin/'):
    for root, dirs, files in os.walk(dir):
        for name in files:
            if name != '.keep':
                os.remove(os.path.join(root, name))
              Severity: Minor
              Found in external/source/shellcode/windows/x86/build.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function locate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def locate(src_file, dir='./src/'):
    for root, dirs, files in os.walk(dir):
        for name in files:
            if src_file == name:
                return root
              Severity: Minor
              Found in external/source/shellcode/windows/x86/build.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              def xmit_dump_ruby(data, length=16):
    dump = ''
    for i in range(0, len(data), length):
        bytes = data[i: i+length]
        hex = "\"%s\"" % (''.join(['\\x%02X' % x for x in bytes]))
              Severity: Major
              Found in external/source/shellcode/windows/x86/build.py and 1 other location - About 1 day to fix
              external/source/shellcode/windows/x64/build.py on lines 49..57

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 123.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              def build(name):
    location = locate('%s.asm' % name)
    if location:
        input = os.path.normpath(os.path.join(location, name))
        output = os.path.normpath(os.path.join('./bin/', name))
              Severity: Major
              Found in external/source/shellcode/windows/x86/build.py and 1 other location - About 7 hrs to fix
              external/source/shellcode/windows/x64/build.py on lines 37..47

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 120.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              def locate(src_file, dir='./src/'):
    for root, dirs, files in os.walk(dir):
        for name in files:
            if src_file == name:
                return root
              Severity: Major
              Found in external/source/shellcode/windows/x86/build.py and 1 other location - About 1 hr to fix
              external/source/shellcode/windows/x64/build.py on lines 30..35

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                              for root, dirs, files in os.walk('./src/single/'):
                    for name in files:
                        build(name[:-4])
              Severity: Major
              Found in external/source/shellcode/windows/x86/build.py and 5 other locations - About 45 mins to fix
              external/source/shellcode/windows/x86/build.py on lines 109..111
              external/source/shellcode/windows/x86/build.py on lines 112..114
              external/source/shellcode/windows/x86/build.py on lines 118..120
              external/source/shellcode/windows/x86/build.py on lines 121..123
              external/source/shellcode/windows/x86/build.py on lines 124..126

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                              for root, dirs, files in os.walk('./src/stage/'):
                    for name in files:
                        build(name[:-4])
              Severity: Major
              Found in external/source/shellcode/windows/x86/build.py and 5 other locations - About 45 mins to fix
              external/source/shellcode/windows/x86/build.py on lines 109..111
              external/source/shellcode/windows/x86/build.py on lines 112..114
              external/source/shellcode/windows/x86/build.py on lines 115..117
              external/source/shellcode/windows/x86/build.py on lines 121..123
              external/source/shellcode/windows/x86/build.py on lines 124..126

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                              for root, dirs, files in os.walk('./src/stager/'):
                    for name in files:
                        build(name[:-4])
              Severity: Major
              Found in external/source/shellcode/windows/x86/build.py and 5 other locations - About 45 mins to fix
              external/source/shellcode/windows/x86/build.py on lines 109..111
              external/source/shellcode/windows/x86/build.py on lines 112..114
              external/source/shellcode/windows/x86/build.py on lines 115..117
              external/source/shellcode/windows/x86/build.py on lines 118..120
              external/source/shellcode/windows/x86/build.py on lines 124..126

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                              for root, dirs, files in os.walk('./src/migrate/'):
                    for name in files:
                        build(name[:-4])
              Severity: Major
              Found in external/source/shellcode/windows/x86/build.py and 5 other locations - About 45 mins to fix
              external/source/shellcode/windows/x86/build.py on lines 109..111
              external/source/shellcode/windows/x86/build.py on lines 115..117
              external/source/shellcode/windows/x86/build.py on lines 118..120
              external/source/shellcode/windows/x86/build.py on lines 121..123
              external/source/shellcode/windows/x86/build.py on lines 124..126

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                              for root, dirs, files in os.walk('./src/egghunter/'):
                    for name in files:
                        build(name[:-4])
              Severity: Major
              Found in external/source/shellcode/windows/x86/build.py and 5 other locations - About 45 mins to fix
              external/source/shellcode/windows/x86/build.py on lines 112..114
              external/source/shellcode/windows/x86/build.py on lines 115..117
              external/source/shellcode/windows/x86/build.py on lines 118..120
              external/source/shellcode/windows/x86/build.py on lines 121..123
              external/source/shellcode/windows/x86/build.py on lines 124..126

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                              for root, dirs, files in os.walk('./src/kernel/'):
                    for name in files:
                        build(name[:-4])
              Severity: Major
              Found in external/source/shellcode/windows/x86/build.py and 5 other locations - About 45 mins to fix
              external/source/shellcode/windows/x86/build.py on lines 109..111
              external/source/shellcode/windows/x86/build.py on lines 112..114
              external/source/shellcode/windows/x86/build.py on lines 115..117
              external/source/shellcode/windows/x86/build.py on lines 118..120
              external/source/shellcode/windows/x86/build.py on lines 121..123

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status