rapid7/metasploit-framework

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    super(update_info(info,
      'Name'           => 'MS07-029 Microsoft DNS RPC Service extractQuotedChar() Overflow (SMB)',
      'Description'    => %q{
          This module exploits a stack buffer overflow in the RPC interface
        of the Microsoft DNS service. The vulnerability is triggered

• Read up
  Read up

Method enum_instance has 199 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def enum_instance(rhost)
    print_status("#{rhost}:#{rport} [SAP] Connecting to SAP Management Console SOAP Interface")
    success = false
    soapenv='http://schemas.xmlsoap.org/soap/envelope/'
    xsi='http://www.w3.org/2001/XMLSchema-instance'

Method build_t3_request_object has 199 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def build_t3_request_object
    # T3 request serialized data
    # retrieved by watching network traffic
    # This is a proprietary, undocumented protocol
    data =  '000005c3'                                     # lenght of the packet

Method cmd_nexpose_scan has 198 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def cmd_nexpose_scan(*args)
        opts = Rex::Parser::Arguments.new(
          '-h' => [ false, 'This help menu'],
          '-t' => [ true, 'The scan template to use (default:pentest-audit options:full-audit,exhaustive-audit,discovery,aggressive-discovery,dos-audit)'],
          '-c' => [ true, 'Specify credentials to use against these targets (format is type:user:pass'],

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def make_js(encoded_payload)

    # The following executes a ret2lib using icucnv36.dll
    # The effect is to bypass DEP and execute the shellcode in an indirect way
    stack_data = [

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def make_js(encoded_payload)

    # The following executes a ret2lib using icucnv36.dll
    # The effect is to bypass DEP and execute the shellcode in an indirect way
    stack_data = [

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  def on_request_uri(cli, request)
    # Re-generate the payload.
    return if ((p = regenerate_payload(cli)) == nil)

    # Encode the shellcode.

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  def on_request_uri(cli, request)
    # Re-generate the payload.
    return if ((p = regenerate_payload(cli)) == nil)

    # Encode the shellcode.

• Read up
  Read up

Class ConsoleCommandDispatcher has 55 methods (exceeds 20 allowed). Consider refactoring.

Open

    class ConsoleCommandDispatcher
      include Msf::Ui::Console::CommandDispatcher

      def name
        PLUGIN_NAME

Identical blocks of code found in 2 locations. Consider refactoring.

Open

def build(name):
    location = locate('%s.asm' % name)
    if location:
        input = os.path.normpath(os.path.join(location, name))
        output = os.path.normpath(os.path.join('./bin/', name))

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

def build(name):
    location = locate('%s.asm' % name)
    if location:
        input = os.path.normpath(os.path.join(location, name))
        output = os.path.normpath(os.path.join('./bin/', name))

• Read up
  Read up

Method exploit has 195 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def exploit
    # lots of this file's format is based on pkexec.rb

    # direct copy of code from exploit-db
    main = %q{

Method cmd_reg has 195 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def cmd_reg(*args)
    # Extract the command, if any
    cmd = args.shift

    if (args.length == 0)

Method init has 194 lines of code (exceeds 25 allowed). Consider refactoring.

Open

   @SuppressWarnings("unchecked")
   public void init()
     {
    try
      {

Method exploit has 194 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def exploit
    print_status('Trying to detect if target is running a supported version of piwik')
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalized_index

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        def recv_telnet(fd, timeout)

          data = ''

          begin

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  def recv_telnet(fd, timeout)

    data = ''

    begin

• Read up
  Read up

Method parse_server has 192 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def parse_server(data)
    creds = []
    perms = []
    groups = []
    settings = {}

Method build_t3_request_object has 191 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def build_t3_request_object
    # T3 request serialized data
    # retrieved by watching network traffic
    # This is a proprietary, undocumented protocol
    # TODO: WHAT DOES THIS DO?  CAN WE RANDOMIZE ANY OF IT?

Method exploit has 191 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def exploit
    # Hijacking Administrator session by exploiting objection injection vuln that end up with sqli
    print_status("Hijacking administrator session")

    sql = "SELECT id FROM sessions LIMIT 1"