Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star

Showing 7,361 of 22,177 total issues

Method sign_jar has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def sign_jar(cert_cn, unsiged_jar, signed_jar, cert_alias="signFiles", msf_keystore="msfkeystore",
      msf_store_pass="msfstorepass", msf_key_pass="msfkeypass")
Severity: Major
Found in lib/msf/core/exploit/java.rb - About 50 mins to fix

    Method start_http_fetch_handler has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def start_http_fetch_handler(srvname, srvexe, ssl=false, ssl_cert=nil, ssl_compression=nil, ssl_cipher=nil, ssl_version=nil)
    Severity: Major
    Found in lib/msf/core/payload/adapter/fetch/server/http.rb - About 50 mins to fix

      Method routine_control has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def routine_control(bus, src_id, dst_id, routine_type, id, data = [], opt = {})
      Severity: Major
      Found in lib/msf/core/post/hardware/automotive/uds.rb - About 50 mins to fix

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          def process_options(cli, request)
    vprint_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
        Severity: Major
        Found in modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb and 9 other locations - About 50 mins to fix
        modules/auxiliary/gather/ie_sandbox_findfiles.rb on lines 175..190
        modules/auxiliary/server/capture/http_ntlm.rb on lines 97..111
        modules/auxiliary/server/http_ntlmrelay.rb on lines 124..138
        modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 125..139
        modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 101..116
        modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 117..131
        modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 113..127
        modules/exploits/windows/misc/wireshark_lua.rb on lines 106..121
        modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 96..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          def process_options(cli, request)
    vprint_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
        Severity: Major
        Found in modules/exploits/windows/http/sap_host_control_cmd_exec.rb and 9 other locations - About 50 mins to fix
        modules/auxiliary/gather/ie_sandbox_findfiles.rb on lines 175..190
        modules/auxiliary/server/capture/http_ntlm.rb on lines 97..111
        modules/auxiliary/server/http_ntlmrelay.rb on lines 124..138
        modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 171..185
        modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 125..139
        modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 101..116
        modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 113..127
        modules/exploits/windows/misc/wireshark_lua.rb on lines 106..121
        modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 96..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          def process_options(cli, request)
    print_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
        Severity: Major
        Found in modules/exploits/windows/browser/webdav_dll_hijacker.rb and 9 other locations - About 50 mins to fix
        modules/auxiliary/gather/ie_sandbox_findfiles.rb on lines 175..190
        modules/auxiliary/server/capture/http_ntlm.rb on lines 97..111
        modules/auxiliary/server/http_ntlmrelay.rb on lines 124..138
        modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 171..185
        modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 101..116
        modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 117..131
        modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 113..127
        modules/exploits/windows/misc/wireshark_lua.rb on lines 106..121
        modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 96..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          def process_options(cli, request)
    print_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
        Severity: Major
        Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb and 9 other locations - About 50 mins to fix
        modules/auxiliary/gather/ie_sandbox_findfiles.rb on lines 175..190
        modules/auxiliary/server/capture/http_ntlm.rb on lines 97..111
        modules/auxiliary/server/http_ntlmrelay.rb on lines 124..138
        modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 171..185
        modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 125..139
        modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 101..116
        modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 117..131
        modules/exploits/windows/misc/wireshark_lua.rb on lines 106..121
        modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 96..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          def process_options(cli, request)
    print_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
        Severity: Major
        Found in modules/auxiliary/server/http_ntlmrelay.rb and 9 other locations - About 50 mins to fix
        modules/auxiliary/gather/ie_sandbox_findfiles.rb on lines 175..190
        modules/auxiliary/server/capture/http_ntlm.rb on lines 97..111
        modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 171..185
        modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 125..139
        modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 101..116
        modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 117..131
        modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 113..127
        modules/exploits/windows/misc/wireshark_lua.rb on lines 106..121
        modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 96..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          def process_options(cli, request)
    print_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
        Severity: Major
        Found in modules/auxiliary/server/capture/http_ntlm.rb and 9 other locations - About 50 mins to fix
        modules/auxiliary/gather/ie_sandbox_findfiles.rb on lines 175..190
        modules/auxiliary/server/http_ntlmrelay.rb on lines 124..138
        modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 171..185
        modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 125..139
        modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 101..116
        modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 117..131
        modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 113..127
        modules/exploits/windows/misc/wireshark_lua.rb on lines 106..121
        modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 96..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          def process_options(cli, request)
    vprint_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
        Severity: Major
        Found in modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb and 9 other locations - About 50 mins to fix
        modules/auxiliary/gather/ie_sandbox_findfiles.rb on lines 175..190
        modules/auxiliary/server/capture/http_ntlm.rb on lines 97..111
        modules/auxiliary/server/http_ntlmrelay.rb on lines 124..138
        modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 171..185
        modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 125..139
        modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 101..116
        modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 117..131
        modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 113..127
        modules/exploits/windows/misc/wireshark_lua.rb on lines 106..121

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          def process_options(cli, request)
    print_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
        Severity: Major
        Found in modules/auxiliary/gather/ie_sandbox_findfiles.rb and 9 other locations - About 50 mins to fix
        modules/auxiliary/server/capture/http_ntlm.rb on lines 97..111
        modules/auxiliary/server/http_ntlmrelay.rb on lines 124..138
        modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 171..185
        modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 125..139
        modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 101..116
        modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 117..131
        modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 113..127
        modules/exploits/windows/misc/wireshark_lua.rb on lines 106..121
        modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 96..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

          def on_request_uri(cli, request)

    case request.method
    when 'OPTIONS'
      process_options(cli, request)
        Severity: Major
        Found in modules/exploits/windows/email/ms10_045_outlook_ref_only.rb and 2 other locations - About 50 mins to fix
        modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb on lines 63..77
        modules/exploits/windows/email/ms10_045_outlook_ref_resolve.rb on lines 77..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

          def on_client_connect(cli)
    peer = "#{cli.peerhost}:#{cli.peerport}"

    case @stage
    when :exe
        Severity: Major
        Found in modules/exploits/windows/ftp/freefloatftp_wbem.rb and 2 other locations - About 50 mins to fix
        modules/exploits/windows/ftp/open_ftpd_wbem.rb on lines 76..89
        modules/exploits/windows/ftp/quickshare_traversal_write.rb on lines 76..90

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

          def on_request_uri(cli, request)

    case request.method
    when 'OPTIONS'
      process_options(cli, request)
        Severity: Major
        Found in modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb and 2 other locations - About 50 mins to fix
        modules/exploits/windows/email/ms10_045_outlook_ref_only.rb on lines 81..95
        modules/exploits/windows/email/ms10_045_outlook_ref_resolve.rb on lines 77..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          def process_options(cli, request)
    vprint_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
        Severity: Major
        Found in modules/exploits/windows/fileformat/mcafee_showreport_exec.rb and 9 other locations - About 50 mins to fix
        modules/auxiliary/gather/ie_sandbox_findfiles.rb on lines 175..190
        modules/auxiliary/server/capture/http_ntlm.rb on lines 97..111
        modules/auxiliary/server/http_ntlmrelay.rb on lines 124..138
        modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 171..185
        modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 125..139
        modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 117..131
        modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 113..127
        modules/exploits/windows/misc/wireshark_lua.rb on lines 106..121
        modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 96..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

          def on_client_connect(cli)
    peer = "#{cli.peerhost}:#{cli.peerport}"

    case @stage
    when :exe
        Severity: Major
        Found in modules/exploits/windows/ftp/quickshare_traversal_write.rb and 2 other locations - About 50 mins to fix
        modules/exploits/windows/ftp/freefloatftp_wbem.rb on lines 67..81
        modules/exploits/windows/ftp/open_ftpd_wbem.rb on lines 76..89

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 10 locations. Consider refactoring.
        Open

          def process_options(cli, request)
    vprint_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
        Severity: Major
        Found in modules/exploits/windows/misc/wireshark_lua.rb and 9 other locations - About 50 mins to fix
        modules/auxiliary/gather/ie_sandbox_findfiles.rb on lines 175..190
        modules/auxiliary/server/capture/http_ntlm.rb on lines 97..111
        modules/auxiliary/server/http_ntlmrelay.rb on lines 124..138
        modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 171..185
        modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 125..139
        modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 101..116
        modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 117..131
        modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 113..127
        modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 96..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

          def on_request_uri(cli, request)

    case request.method
    when 'OPTIONS'
      process_options(cli, request)
        Severity: Major
        Found in modules/exploits/windows/email/ms10_045_outlook_ref_resolve.rb and 2 other locations - About 50 mins to fix
        modules/exploits/windows/browser/ms10_046_shortcut_icon_dllloader.rb on lines 63..77
        modules/exploits/windows/email/ms10_045_outlook_ref_only.rb on lines 81..95

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

          def on_client_connect(cli)
    peer = "#{cli.peerhost}:#{cli.peerport}"

    case @stage
    when :exe
        Severity: Major
        Found in modules/exploits/windows/ftp/open_ftpd_wbem.rb and 2 other locations - About 50 mins to fix
        modules/exploits/windows/ftp/freefloatftp_wbem.rb on lines 67..81
        modules/exploits/windows/ftp/quickshare_traversal_write.rb on lines 76..90

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

          def self.get_session_event
    lambda {
      warden.authenticate!
      begin
        sanitized_params = sanitize_params(params, env['rack.request.query_hash'])
        Severity: Major
        Found in lib/msf/core/web_services/servlet/session_event_servlet.rb and 5 other locations - About 50 mins to fix
        lib/msf/core/web_services/servlet/event_servlet.rb on lines 21..31
        lib/msf/core/web_services/servlet/host_servlet.rb on lines 35..45
        lib/msf/core/web_services/servlet/login_servlet.rb on lines 23..33
        lib/msf/core/web_services/servlet/payload_servlet.rb on lines 36..46
        lib/msf/core/web_services/servlet/vuln_attempt_servlet.rb on lines 21..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language