rapid7/metasploit-framework

View on GitHub

Showing 7,361 of 22,177 total issues

Method cmd_set has 106 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def cmd_set(*args)
    # Figure out if these are global variables
    global = false
    append = false
    clear = false
Severity: Major
Found in lib/msf/ui/console/command_dispatcher/core.rb - About 4 hrs to fix

    Method cmd_vulns has 106 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def cmd_vulns(*args)
        return unless active?
    
        default_columns = ['Timestamp', 'Host', 'Name', 'References']
        host_ranges = []
    Severity: Major
    Found in lib/msf/ui/console/command_dispatcher/db.rb - About 4 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            if(datastore['JOHNPWFILE'] and user)
              case ntlm_ver
              when NTLM_CONST::NTLM_V1_RESPONSE, NTLM_CONST::NTLM_2_SESSION_RESPONSE
                fd = File.open(datastore['JOHNPWFILE'] + '_netntlm', "ab")
                fd.puts(
      Severity: Major
      Found in modules/auxiliary/server/capture/mssql.rb and 1 other location - About 4 hrs to fix
      modules/auxiliary/server/capture/http_ntlm.rb on lines 353..395

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 144.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            if(datastore['JOHNPWFILE'] and user)
              case ntlm_ver
              when NTLM_CONST::NTLM_V1_RESPONSE, NTLM_CONST::NTLM_2_SESSION_RESPONSE
      
                fd = File.open(datastore['JOHNPWFILE'] + '_netntlm', "ab")
      Severity: Major
      Found in modules/auxiliary/server/capture/http_ntlm.rb and 1 other location - About 4 hrs to fix
      modules/auxiliary/server/capture/mssql.rb on lines 305..345

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 144.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method getprocparam has 105 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def getprocparam(rhost)
          print_status("[SAP] Connecting to SAP Management Console SOAP Interface on #{rhost}:#{rport}")
          success = false
          soapenv = 'http://schemas.xmlsoap.org/soap/envelope/'
          xsi = 'http://www.w3.org/2001/XMLSchema-instance'
      Severity: Major
      Found in modules/auxiliary/scanner/sap/sap_mgmt_con_getprocessparameter.rb - About 4 hrs to fix

        Method initialize has 105 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(info = {})
            super(
              update_info(
                info,
                'Name' => 'Oracle WebLogic Server Administration Console Handle RCE',
        Severity: Major
        Found in modules/exploits/multi/http/weblogic_admin_handle_rce.rb - About 4 hrs to fix

          Method initialize has 105 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def initialize(info={})
              super(update_info(info,
                'Name'           => "ManageEngine Desktop Central / Password Manager LinkViewFetchServlet.dat SQL Injection",
                'Description'    => %q{
                  This module exploits an unauthenticated blind SQL injection in LinkViewFetchServlet,
          Severity: Major
          Found in modules/exploits/multi/http/manage_engine_dc_pmp_sqli.rb - About 4 hrs to fix

            Method initialize has 105 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def initialize(info = {})
                super(
                  update_info(
                    info,
                    'Name' => 'Citrix ADC (NetScaler) Forms SSO Target RCE',
            Severity: Major
            Found in modules/exploits/freebsd/http/citrix_formssso_target_rce.rb - About 4 hrs to fix

              Method process_propfind has 105 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def process_propfind(cli, request)
                  path = request.uri
                  print_status("PROPFIND #{path}")
                  body = ''
              
              
              Severity: Major
              Found in modules/exploits/windows/browser/webdav_dll_hijacker.rb - About 4 hrs to fix

                Method on_request_uri has 105 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def on_request_uri(cli, request)
                
                    if (request.uri.match(/payload/))
                      return if ((p = regenerate_payload(cli)) == nil)
                      data = generate_payload_exe({ :code => p.encoded })
                Severity: Major
                Found in modules/exploits/windows/browser/ie_createobject.rb - About 4 hrs to fix

                  Method process_propfind has 105 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def process_propfind(cli, request)
                      path = request.uri
                      vprint_status("PROPFIND #{path}")
                      body = ''
                  
                  
                  Severity: Major
                  Found in modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb - About 4 hrs to fix

                    Method process_propfind has 105 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      def process_propfind(cli, request)
                        path = request.uri
                        print_status("PROPFIND #{path}")
                        body = ''
                    
                    
                    Severity: Major
                    Found in modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb - About 4 hrs to fix

                      Method dispatch_request has 105 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        def dispatch_request(from, buf)
                          type = buf.unpack('C').first
                          if (type != Constants::Request)
                            #dlog("Unknown DHCP request type: #{type}")
                            return
                      Severity: Major
                      Found in lib/rex/proto/dhcp/server.rb - About 4 hrs to fix

                        Method cmd_jobs has 105 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                  def cmd_jobs(*args)
                                    # Make the default behavior listing all jobs if there were no options
                                    # or the only option is the verbose flag
                                    args.unshift("-l") if args.empty? || args == ["-v"]
                        
                        
                        Severity: Major
                        Found in lib/msf/ui/console/command_dispatcher/jobs.rb - About 4 hrs to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              this.assignSub = operation(function sub(a, b) {
                                  var carry = 0;
                                  for (var i = 0; i < 8; i++) {
                                      var cur = a.byteAt(i) - b.byteAt(i) - carry;
                                      carry = cur < 0 | 0;
                          Severity: Major
                          Found in data/exploits/javascript_utils/int64.js and 1 other location - About 4 hrs to fix
                          data/exploits/javascript_utils/int64.js on lines 143..151

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 119.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              this.assignAdd = operation(function add(a, b) {
                                  var carry = 0;
                                  for (var i = 0; i < 8; i++) {
                                      var cur = a.byteAt(i) + b.byteAt(i) + carry;
                                      carry = cur > 0xff | 0;
                          Severity: Major
                          Found in data/exploits/javascript_utils/int64.js and 1 other location - About 4 hrs to fix
                          data/exploits/javascript_utils/int64.js on lines 154..162

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 119.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              script = %Q|
                              var #{rand1} = unescape("#{shellcode}");
                              var #{rand2} ="";
                              for (#{rand3}=128;#{rand3}>=0;--#{rand3}) #{rand2} += unescape("#{nops}");
                              #{rand4} = #{rand2} + #{rand1};
                          modules/exploits/windows/browser/hyleos_chemviewx_activex.rb on lines 100..116

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 143.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              content = %Q|<html>
                          <object classid='clsid:#{clsid}' id='#{chemview}'></object>
                          <script>
                          #{j_shellcode}=unescape('#{shellcode}');
                          #{j_nops}=unescape('#{nops}');
                          Severity: Major
                          Found in modules/exploits/windows/browser/hyleos_chemviewx_activex.rb and 1 other location - About 4 hrs to fix
                          modules/exploits/windows/fileformat/adobe_collectemailinfo.rb on lines 73..89

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 143.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Method run has 104 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            def run
                              res = xymon_send('ping').to_s
                          
                              unless res.starts_with? 'xymond'
                                print_error 'Target is not a Xymon daemon'
                          Severity: Major
                          Found in modules/auxiliary/gather/xymon_info.rb - About 4 hrs to fix

                            Method run has 104 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              def run
                                headings = [
                                  ["Database", "Schema", "Table", "Column", "Data Type", "Row Count"]
                                ]
                            
                            
                            Severity: Major
                            Found in modules/auxiliary/admin/mssql/mssql_idf.rb - About 4 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language