Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star

Showing 21,886 of 21,886 total issues

Method reset_ecu has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def reset_ecu(bus, src_id, dst_id, hard, opt = {})
Severity: Minor
Found in lib/msf/core/post/hardware/automotive/uds.rb - About 35 mins to fix

    Method read_data_by_id has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def read_data_by_id(bus, src_id, dst_id, id, opt = {})
    Severity: Minor
    Found in lib/msf/core/post/hardware/automotive/uds.rb - About 35 mins to fix

      Method shell_registry_setvaldata has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def shell_registry_setvaldata(key, valname, data, type, view)
      Severity: Minor
      Found in lib/msf/core/post/windows/registry.rb - About 35 mins to fix

        Method get_security_token has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def get_security_token(bus, src_id, dst_id, level = 1, opt = {})
        Severity: Minor
        Found in lib/msf/core/post/hardware/automotive/uds.rb - About 35 mins to fix

          Method meterpreter_registry_setvaldata has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def meterpreter_registry_setvaldata(key, valname, data, type, view)
          Severity: Minor
          Found in lib/msf/core/post/windows/registry.rb - About 35 mins to fix

            Method get_current_data has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              def get_current_data(bus, src_id, dst_id, pid, opt = {})
            Severity: Minor
            Found in lib/msf/core/post/hardware/automotive/uds.rb - About 35 mins to fix

              Method registry_setvaldata has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def registry_setvaldata(key, valname, data, type, view = REGISTRY_VIEW_NATIVE)
              Severity: Minor
              Found in lib/msf/core/post/windows/registry.rb - About 35 mins to fix

                Method query_ldap has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        def query_ldap(session_handle, base, scope, filter, fields)
                Severity: Minor
                Found in lib/msf/core/post/windows/ldap.rb - About 35 mins to fix

                  Method set_dsc has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    def set_dsc(bus, src_id, dst_id, level, opt = {})
                  Severity: Minor
                  Found in lib/msf/core/post/hardware/automotive/uds.rb - About 35 mins to fix

                    Method create_process_with_logon has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                      def create_process_with_logon(domain, user, password, application_name, command_line)
                    Severity: Minor
                    Found in lib/msf/core/post/windows/runas.rb - About 35 mins to fix

                      Method find_files has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              def find_files(userprofile, application, artifact, path, dir)
                      Severity: Minor
                      Found in lib/msf/core/post/windows/packrat.rb - About 35 mins to fix

                        Method create_process_as_user has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                          def create_process_as_user(domain, user, password, application_name, command_line)
                        Severity: Minor
                        Found in lib/msf/core/post/windows/runas.rb - About 35 mins to fix

                          Method add_reg_key_value has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  def add_reg_key_value(reg_key, reg_value, reg_data, reg_type, opts = {})
                          Severity: Minor
                          Found in lib/msf/core/post/windows/task_scheduler.rb - About 35 mins to fix

                            Method send_wrapper has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    def send_wrapper(sock, pkt, host, port, flags)
                            Severity: Minor
                            Found in lib/metasploit/framework/login_scanner/snmp.rb - About 35 mins to fix

                              Method CfCreatePlaceholders has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                          string BaseDirectoryPath,
            [In, Out, MarshalAs(UnmanagedType.LPArray)] CF_PLACEHOLDER_CREATE_INFO[] PlaceholderArray,
            int PlaceholderCount,
            CF_CREATE_FLAGS CreateFlags,
            out int EntriesProcessed
                              Severity: Minor
                              Found in external/source/exploits/CVE-2020-17136/POC_CloudFilter_ArbitraryFile_EoP/Program.cs - About 35 mins to fix

                                Method sign has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                        def sign(creds, service, headers, body_digest, now)
                                Severity: Minor
                                Found in lib/metasploit/framework/aws/client.rb - About 35 mins to fix

                                  Method CfHydratePlaceholder has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                              SafeHandle FileHandle,
            LargeIntegerStruct StartingOffset,
            LargeIntegerStruct Length,
            CF_HYDRATE_FLAGS HydrateFlags,
            IntPtr Overlapped
                                  Severity: Minor
                                  Found in external/source/exploits/CVE-2020-17136/POC_CloudFilter_ArbitraryFile_EoP/Program.cs - About 35 mins to fix

                                    Method auth has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                            def auth(creds, service, headers, body_digest, now)
                                    Severity: Minor
                                    Found in lib/metasploit/framework/aws/client.rb - About 35 mins to fix

                                      Method CfConnectSyncRoot has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                                  string SyncRootPath,
            [MarshalAs(UnmanagedType.LPArray), In] CF_CALLBACK_REGISTRATION[] CallbackTable,
            IntPtr CallbackContext,
            CF_CONNECT_FLAGS ConnectFlags,
            out long ConnectionKey
                                      Severity: Minor
                                      Found in external/source/exploits/CVE-2020-17136/POC_CloudFilter_ArbitraryFile_EoP/Program.cs - About 35 mins to fix

                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                            public int getType()
    {
        String caller = java.lang.Thread.currentThread().getStackTrace()[2].toString();
        if (caller.contains("ICC_Transform.getImageLayout(")) {
            return this._fakeType;
                                        Severity: Minor
                                        Found in external/source/exploits/cve-2013-1493/MyBufferedImage.java and 1 other location - About 35 mins to fix
                                        external/source/exploits/cve-2013-1493/MyBufferedImage.java on lines 40..48

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 47.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language