rapid7/metasploit-framework

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  def check
    # sanity check to see if the target is likely OpenTSDB
    res1 = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path)

• Read up
  Read up

File vcenter_forge_saml_token.rb has 321 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'metasploit/framework/credential_collection'

class MetasploitModule < Msf::Auxiliary
  include Msf::Auxiliary::WmapScanUniqueQuery
  include Msf::Exploit::Remote::HttpClient

File piwik_superuser_plugin_upload.rb has 321 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rex/zip'

class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

File file.rb has 321 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rex/post/file'
require 'rex/post/meterpreter/channel'
require 'rex/post/meterpreter/channels/pools/file'
require 'rex/post/meterpreter/extensions/stdapi/stdapi'
require 'rex/post/meterpreter/extensions/stdapi/fs/io'

File base.rb has 321 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'msf/core/constants'
# Responsible for loading modules for {Msf::ModuleManager}.
#
# @abstract Subclass and override {#each_module_reference_name}, {#loadable?}, {#module_path}, and
#   {#read_module_content}.

File enumeration.rb has 321 lines of code (exceeds 250 allowed). Consider refactoring.

Open

module Msf

###
#
# This module exposes methods for querying a remote DNS service

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        print_status('Preparing ROP chain for target 1.3.8.42!')

        # 0x140cd00a9 | add rsp, 0x10 ; ret
        # This is needed because the next 16 bytes are sometimes messed up.
        overwrite = [0x140cd00a9].pack('Q<')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        print_status('Preparing ROP chain for target 1.4.2.37!')

        # 0x140cd9759 | add rsp, 0x10 ; ret
        # This is needed because the next 16 bytes are sometimes messed up.
        overwrite = [0x140cd9759].pack('Q<')

• Read up
  Read up

Method run has 92 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def run
    begin
      @port = datastore['SRVPORT'].to_i
      @sock = Rex::Socket::Udp.create(
            'LocalHost' => datastore['SRVHOST'],

Method run_host has 92 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def run_host(ip)
    snmp = connect_snmp

    if snmp.get_value('sysDescr.0') =~ /DG950A/
      print_line("#{ip}")

Method run_host has 92 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def run_host(ip)
    self.postgres_conn = session.client if session
    # Query the Postgres Shadow table for username and password hashes and report them
    res = postgres_query('SELECT usename, passwd FROM pg_shadow',false)

Method initialize has 92 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def initialize(info = {})
    super(merge_info(info,
      'Name'          => 'OS X Write and Execute Binary',
      'Description'   => 'Spawn a command shell (staged)',
      'Author'        => 'hdm',

Method exploit has 92 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def exploit
    # Need to grab the PHP session cookie value first to pass to application
    vprint_status('Gathering PHP session cookie')
    if datastore['SSL'] == true
      vprint_status('SSL is true, changing protocol to HTTPS')

File chrome_object_create.rb has 320 lines of code (exceeds 250 allowed). Consider refactoring.

Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = ManualRanking

  include Msf::Post::File
  include Msf::Exploit::Remote::HttpServer::BrowserExploit

File dlink_upnp_msearch_exec.rb has 320 lines of code (exceeds 250 allowed). Consider refactoring.

Open

class MetasploitModule < Msf::Exploit::Remote
  Rank = ExcellentRanking

  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::CmdStager

Method initialize has 92 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name'           => 'Service Persistence',

File shell.rb has 320 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require 'rex/text/color'

module Rex
module Ui
module Text

Method import_libpcap has 92 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def import_libpcap(args={}, &block)
    data = args[:data]
    wspace = Msf::Util::DBManager.process_opts_workspace(args, framework).name
    bl = validate_ips(args[:blacklist]) ? args[:blacklist].split : []
    # seen_hosts is only used for determining when to yield an address. Once we get

Class SessionNotifierCommandDispatcher has 30 methods (exceeds 20 allowed). Consider refactoring.

Open

    class SessionNotifierCommandDispatcher

      include Msf::Ui::Console::CommandDispatcher

      attr_reader :sms_client, :sms_carrier, :sms_number, :smtp_address, :smtp_port, :smtp_username, :smtp_password, :smtp_from, :minimum_ip, :maximum_ip, :dingtalk_webhook, :gotify_address, :gotify_sslcert_path, :serverjang_webhook

Class MetasploitModule has 30 methods (exceeds 20 allowed). Consider refactoring.

Open

class MetasploitModule < Msf::Post
  include Msf::Post::File
  include Msf::Post::Windows::UserProfiles
  include Msf::Post::OSX::System
  include Msf::Post::Unix