Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/metasploit/framework/login_scanner/base.rb

Summary

Maintainability
D
1 day
Test Coverage

Method scan! has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
Open

          def scan!
            valid!

            # Keep track of connection errors.
            # If we encounter too many, we will stop.
Severity: Minor
Found in lib/metasploit/framework/login_scanner/base.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method scan! has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

          def scan!
            valid!

            # Keep track of connection errors.
            # If we encounter too many, we will stop.
Severity: Minor
Found in lib/metasploit/framework/login_scanner/base.rb - About 2 hrs to fix

    Method host_address_must_be_valid has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

              def host_address_must_be_valid
            if host.kind_of? String
              begin
                resolved_host = ::Rex::Socket.getaddress(host, true)
                if host =~ /^\d{1,3}(\.\d{1,3}){1,3}$/
    Severity: Minor
    Found in lib/metasploit/framework/login_scanner/base.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method each_credential has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

              def each_credential
            cred_details.each do |raw_cred|

              # This could be a Credential object, or a Credential Core, or an Attempt object
              # so make sure that whatever it is, we end up with a Credential.
    Severity: Minor
    Found in lib/metasploit/framework/login_scanner/base.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status