lib/metasploit/framework/password_crackers/jtr/formatter.rb
Method hash_to_jtr has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring. Open
Open
def self.hash_to_jtr(cred)
case cred.private.type
when 'Metasploit::Credential::NTLMHash'
return "#{cred.public.username}:#{cred.id}:#{cred.private.data}:::#{cred.id}"
when 'Metasploit::Credential::PostgresMD5'- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method hash_to_jtr has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def self.hash_to_jtr(cred)
case cred.private.type
when 'Metasploit::Credential::NTLMHash'
return "#{cred.public.username}:#{cred.id}:#{cred.private.data}:::#{cred.id}"
when 'Metasploit::Credential::PostgresMD5'Method jtr_to_db has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def self.jtr_to_db(cred_type)
case cred_type
when 'descrypt' # from aix module
return ['des']
when 'oracle' # from databases moduleAvoid too many return statements within this method. Open
Open
return "#{cred.public.username.upcase}:$dynamic_1506$#{Regexp.last_match(1)}:#{cred.id}:"Avoid too many return statements within this method. Open
Open
return "#{cred.public.username}:O$#{cred.public.username}##{cred.private.data}:#{cred.id}:"Avoid too many return statements within this method. Open
Open
return "#{cred.private.data}::::::#{cred.id}:"Avoid too many return statements within this method. Open
Open
return ['bf']Avoid too many return statements within this method. Open
Open
return "#{cred.public.username}:#{cred.private.data}:::::#{cred.id}:"Avoid too many return statements within this method. Open
Open
return "#{cred.public.username}:#{hash}"Avoid too many return statements within this method. Open
Open
return ['md5']Avoid too many return statements within this method. Open
Open
return "$vnc$#{cred.private.data.start_with?('*') ? cred.private.data.upcase : "*#{cred.private.data.upcase}"}"Avoid too many return statements within this method. Open
Open
return "#{cred.public.nil? ? ' ' : cred.public.username}:#{cred.private.data}:#{cred.id}:"Avoid too many return statements within this method. Open
Open
return ['pbkdf2,oracle12c']Avoid too many return statements within this method. Open
Open
return ['sha256,crypt']Avoid too many return statements within this method. Open
Open
return "#{cred.public.username}:#{cred.private.data.upcase}:::::#{cred.id}:"Avoid too many return statements within this method. Open
Open
return ['des']Avoid too many return statements within this method. Open
Open
return ['bsdi']Avoid too many return statements within this method. Open
Open
return "#{cred.private.data}:"Avoid too many return statements within this method. Open
Open
return ['raw-md5,postgres']Avoid too many return statements within this method. Open
Open
return [cred_type]Avoid too many return statements within this method. Open
Open
return ['sha512,crypt']