Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/base/sessions/meterpreter.rb

Summary

Maintainability
F
3 days
Test Coverage

File meterpreter.rb has 423 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rex/post/meterpreter/client'
require 'rex/post/meterpreter/ui/console'

module Msf
module Sessions
Severity: Minor
Found in lib/msf/base/sessions/meterpreter.rb - About 6 hrs to fix

    Class Meterpreter has 36 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Meterpreter < Rex::Post::Meterpreter::Client

  include Msf::Session
  #
  # The meterpreter session is interactive
    Severity: Minor
    Found in lib/msf/base/sessions/meterpreter.rb - About 4 hrs to fix

      Method find_internet_connected_address has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

        def find_internet_connected_address

    ifaces = self.net.config.get_interfaces().flatten rescue []
    routes = self.net.config.get_routes().flatten rescue []
      Severity: Minor
      Found in lib/msf/base/sessions/meterpreter.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method bootstrap has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

        def bootstrap(datastore = {}, handler = nil)
    session = self

    # Configure unicode encoding before loading stdapi
    session.encode_unicode = datastore['EnableUnicodeEncoding']
      Severity: Minor
      Found in lib/msf/base/sessions/meterpreter.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method load_session_info has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

        def load_session_info
    begin
      ::Timeout.timeout(60) do
        update_session_info
      Severity: Minor
      Found in lib/msf/base/sessions/meterpreter.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method load_session_info has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def load_session_info
    begin
      ::Timeout.timeout(60) do
        update_session_info
      Severity: Major
      Found in lib/msf/base/sessions/meterpreter.rb - About 2 hrs to fix

        Method bootstrap has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def bootstrap(datastore = {}, handler = nil)
    session = self

    # Configure unicode encoding before loading stdapi
    session.encode_unicode = datastore['EnableUnicodeEncoding']
        Severity: Minor
        Found in lib/msf/base/sessions/meterpreter.rb - About 1 hr to fix

          Method find_internet_connected_address has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def find_internet_connected_address

    ifaces = self.net.config.get_interfaces().flatten rescue []
    routes = self.net.config.get_routes().flatten rescue []
          Severity: Minor
          Found in lib/msf/base/sessions/meterpreter.rb - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              def guess_target_platform(os)
    case os
    when /windows/i
      Msf::Module::Platform::Windows.realname.downcase
    when /darwin/i
            Severity: Major
            Found in lib/msf/base/sessions/meterpreter.rb and 1 other location - About 1 hr to fix
            plugins/aggregator.rb on lines 451..465

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              def run_cmd(cmd,output_object=nil)
    stored_output_state = nil
    # If the user supplied an Output IO object, then we tell
    # the console to use that, while saving it's previous output/
    if output_object
            Severity: Minor
            Found in lib/msf/base/sessions/meterpreter.rb and 1 other location - About 20 mins to fix
            lib/msf/base/sessions/sql.rb on lines 36..53

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 27.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status