Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/analyze.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method suggest_modules_for_vulns has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def suggest_modules_for_vulns(eval_host, vuln_families, payloads: nil)
    mrefs, _mports, _mservs = Msf::Modules::Metadata::Cache.instance.all_exploit_maps
    suggested_modules = []

    evaluated_module_targets = Set.new
Severity: Minor
Found in lib/msf/core/analyze.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method suggest_modules_for_vulns has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def suggest_modules_for_vulns(eval_host, vuln_families, payloads: nil)
    mrefs, _mports, _mservs = Msf::Modules::Metadata::Cache.instance.all_exploit_maps
    suggested_modules = []

    evaluated_module_targets = Set.new
Severity: Minor
Found in lib/msf/core/analyze.rb - About 1 hr to fix

    Method group_vulns has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def group_vulns(vulns)
    return [] if vulns.empty?

    vulns = vulns.map do |vuln|
      [vuln, Set.new(vuln.refs.map {|r| r.name.upcase})]
    Severity: Minor
    Found in lib/msf/core/analyze.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method group_vulns has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def group_vulns(vulns)
    return [] if vulns.empty?

    vulns = vulns.map do |vuln|
      [vuln, Set.new(vuln.refs.map {|r| r.name.upcase})]
    Severity: Minor
    Found in lib/msf/core/analyze.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status