Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/auxiliary/http_crawler.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run

    self.request_count = 0
    self.form_count  = 0
    self.url_count   = 0
Severity: Minor
Found in lib/msf/core/auxiliary/http_crawler.rb - About 1 hr to fix

    Method initialize has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super

    register_options(
      [
    Severity: Minor
    Found in lib/msf/core/auxiliary/http_crawler.rb - About 1 hr to fix

      Method crawl_target has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def crawl_target(t)
    cnt  = 0
    opts = crawler_options(t)
    url  = t.to_url
      Severity: Minor
      Found in lib/msf/core/auxiliary/http_crawler.rb - About 1 hr to fix

        Method crawler_options has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def crawler_options(t)
    opts = {}
    opts[:user_agent]      = datastore['UserAgent']
    opts[:verbose]         = false
    opts[:threads]         = max_crawl_threads
        Severity: Minor
        Found in lib/msf/core/auxiliary/http_crawler.rb - About 1 hr to fix

          Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def run

    self.request_count = 0
    self.form_count  = 0
    self.url_count   = 0
          Severity: Minor
          Found in lib/msf/core/auxiliary/http_crawler.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method crawler_process_page has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def crawler_process_page(t, page, cnt)
    return if page.nil? # Skip over pages that don't contain any info aka page is nil. We can't process these types of pages since there is no data to process.
    msg = "[#{"%.5d" % cnt}/#{"%.5d" % max_page_count}]    #{page ? page.code || "ERR" : "ERR"} - #{@current_site.vhost} - #{page.url}"
    case page.code
      when 301,302
          Severity: Minor
          Found in lib/msf/core/auxiliary/http_crawler.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method crawl_target has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def crawl_target(t)
    cnt  = 0
    opts = crawler_options(t)
    url  = t.to_url
          Severity: Minor
          Found in lib/msf/core/auxiliary/http_crawler.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              case page.code
      when 301,302
        if page.headers and page.headers["location"]
          print_status(msg + " -> " + page.headers["location"].to_s)
        else
          Severity: Major
          Found in lib/msf/core/auxiliary/http_crawler.rb and 1 other location - About 1 hr to fix
          modules/auxiliary/scanner/http/crawler.rb on lines 72..89

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status