lib/msf/core/auxiliary/nfs.rb
Method can_mount?
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
Open
def can_mount?(locations, mountable = true, hostname = '', lhost = '')
# attempts to validate if we'll be able to open it or not based on:
# 1. its a wildcard, thus we can open it
# 2. hostname isn't blank and its in the list
# 3. our IP is explicitly listed
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
Open
return true if Rex::Socket::RangeWalker.new(location).include?(lhost)
Avoid too many return
statements within this method. Open
Open
return true if File.fnmatch(location, hostname)