Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/auxiliary/web.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method process_vulnerability has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def process_vulnerability(element, proof, opts = {})
      mode  = name
      vhash = [target.to_url, mode, element.altered]
              .map(&:to_s).join('|').hash
Severity: Minor
Found in lib/msf/core/auxiliary/web.rb - About 2 hrs to fix

    Method log_fingerprint has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def log_fingerprint(opts = {})
      mode  = name
      vhash = [target.to_url, opts[:fingerprint], mode, opts[:location]]
              .map(&:to_s).join('|').hash
    Severity: Minor
    Found in lib/msf/core/auxiliary/web.rb - About 1 hr to fix

      Method log_resource has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def log_resource(opts = {})
      mode  = name
      vhash = [target.to_url, mode, opts[:location]]
              .map(&:to_s).join('|').hash
      Severity: Minor
      Found in lib/msf/core/auxiliary/web.rb - About 1 hr to fix

        Method log_fingerprint has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def log_fingerprint(opts = {})
      mode  = name
      vhash = [target.to_url, opts[:fingerprint], mode, opts[:location]]
              .map(&:to_s).join('|').hash
        Severity: Minor
        Found in lib/msf/core/auxiliary/web.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              info = {
        web_site: target.site,
        path: location.path,
        query: location.query,
        method: 'GET',
        Severity: Minor
        Found in lib/msf/core/auxiliary/web.rb and 1 other location - About 50 mins to fix
        lib/msf/core/auxiliary/web.rb on lines 159..173

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              info = {
        web_site: target.site,
        path: location.path,
        query: location.query,
        method: 'GET',
        Severity: Minor
        Found in lib/msf/core/auxiliary/web.rb and 1 other location - About 50 mins to fix
        lib/msf/core/auxiliary/web.rb on lines 195..209

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status