rapid7/metasploit-framework

View on GitHub
lib/msf/core/db_manager/import/libpcap.rb

Summary

Maintainability
F
3 days
Test Coverage

Method import_libpcap has a Cognitive Complexity of 95 (exceeds 5 allowed). Consider refactoring.
Open

  def import_libpcap(args={}, &block)
    data = args[:data]
    wspace = Msf::Util::DBManager.process_opts_workspace(args, framework).name
    bl = validate_ips(args[:blacklist]) ? args[:blacklist].split : []
    # seen_hosts is only used for determining when to yield an address. Once we get
Severity: Minor
Found in lib/msf/core/db_manager/import/libpcap.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import_libpcap has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def import_libpcap(args={}, &block)
    data = args[:data]
    wspace = Msf::Util::DBManager.process_opts_workspace(args, framework).name
    bl = validate_ips(args[:blacklist]) ? args[:blacklist].split : []
    # seen_hosts is only used for determining when to yield an address. Once we get
Severity: Major
Found in lib/msf/core/db_manager/import/libpcap.rb - About 3 hrs to fix

    Method inspect_single_packet_http has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def inspect_single_packet_http(pkt,wspace,args)
        task = args.fetch(:task, nil)
        # First, check the server side (data from port 80).
        if pkt.is_tcp? and pkt.tcp_src == 80 and !pkt.payload.nil? and !pkt.payload.empty?
          if pkt.payload =~ /^HTTP\x2f1\x2e[01]/n
    Severity: Major
    Found in lib/msf/core/db_manager/import/libpcap.rb - About 2 hrs to fix

      Method inspect_single_packet_http has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

        def inspect_single_packet_http(pkt,wspace,args)
          task = args.fetch(:task, nil)
          # First, check the server side (data from port 80).
          if pkt.is_tcp? and pkt.tcp_src == 80 and !pkt.payload.nil? and !pkt.payload.empty?
            if pkt.payload =~ /^HTTP\x2f1\x2e[01]/n
      Severity: Minor
      Found in lib/msf/core/db_manager/import/libpcap.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                if seen_hosts[saddr]
                  unless seen_hosts[saddr].include? [pkt.udp_src,"udp"]
                    report_service(
                        :workspace => wspace, :host => saddr,
                        :proto     => "udp", :port => pkt.udp_src,
      Severity: Major
      Found in lib/msf/core/db_manager/import/libpcap.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                      unless seen_hosts[xaddr].include? [pkt.udp_src,"udp"]
                        report_service(
                            :workspace => wspace, :host => xaddr,
                            :proto     => "udp", :port => pkt.udp_src,
                            :state     => Msf::ServiceState::Open,
        Severity: Major
        Found in lib/msf/core/db_manager/import/libpcap.rb - About 45 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      if seen_hosts[xaddr]
                        unless seen_hosts[xaddr].include? [pkt.udp_src,"udp"]
                          report_service(
                              :workspace => wspace, :host => xaddr,
                              :proto     => "udp", :port => pkt.udp_src,
          Severity: Major
          Found in lib/msf/core/db_manager/import/libpcap.rb and 2 other locations - About 1 hr to fix
          lib/msf/core/db_manager/import/libpcap.rb on lines 64..73
          lib/msf/core/db_manager/import/libpcap.rb on lines 94..103

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                    if seen_hosts[saddr]
                      unless seen_hosts[saddr].include? [pkt.udp_src,"udp"]
                        report_service(
                            :workspace => wspace, :host => saddr,
                            :proto     => "udp", :port => pkt.udp_src,
          Severity: Major
          Found in lib/msf/core/db_manager/import/libpcap.rb and 2 other locations - About 1 hr to fix
          lib/msf/core/db_manager/import/libpcap.rb on lines 64..73
          lib/msf/core/db_manager/import/libpcap.rb on lines 80..89

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                    if seen_hosts[saddr]
                      unless seen_hosts[saddr].include? [pkt.tcp_src,"tcp"]
                        report_service(
                            :workspace => wspace, :host => saddr,
                            :proto     => "tcp", :port => pkt.tcp_src,
          Severity: Major
          Found in lib/msf/core/db_manager/import/libpcap.rb and 2 other locations - About 1 hr to fix
          lib/msf/core/db_manager/import/libpcap.rb on lines 80..89
          lib/msf/core/db_manager/import/libpcap.rb on lines 94..103

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                unless( bl.include?(daddr) || rfc3330_reserved(daddr))
                  yield(:address,daddr) if block and !seen_hosts.keys.include?(daddr)
                  unless seen_hosts[daddr]
                    report_host(
                        :workspace => wspace,
          Severity: Minor
          Found in lib/msf/core/db_manager/import/libpcap.rb and 1 other location - About 50 mins to fix
          lib/msf/core/db_manager/import/libpcap.rb on lines 35..47

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                unless( bl.include?(saddr) || rfc3330_reserved(saddr))
                  yield(:address,saddr) if block and !seen_hosts.keys.include?(saddr)
                  unless seen_hosts[saddr]
                    report_host(
                        :workspace => wspace,
          Severity: Minor
          Found in lib/msf/core/db_manager/import/libpcap.rb and 1 other location - About 50 mins to fix
          lib/msf/core/db_manager/import/libpcap.rb on lines 48..59

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status