rapid7/metasploit-framework

View on GitHub
lib/msf/core/exploit/java.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method compile has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def compile(classnames, codez, compile_options=nil)
    if !@rjb_loaded or !@jvm_init
      raise RuntimeError, "Could not load rjb and/or the JVM: " + @java_error.to_s
    end

Severity: Minor
Found in lib/msf/core/exploit/java.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sign_jar has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def sign_jar(cert_cn, unsiged_jar, signed_jar, cert_alias="signFiles", msf_keystore="msfkeystore",
      msf_store_pass="msfstorepass", msf_key_pass="msfkeypass")
Severity: Major
Found in lib/msf/core/exploit/java.rb - About 50 mins to fix

    There are no issues that match your filters.

    Category
    Status