Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/exploit/pdf_parse.rb

Summary

Maintainability
C
1 day
Test Coverage

Method xref_create has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def xref_create(stream,offset,num_obj)


    xref = Array.new()
    object = String.new()
Severity: Minor
Found in lib/msf/core/exploit/pdf_parse.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method object_locate has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def object_locate(xref_trailer,obj_name)

    found = false
    match = obj_name.match(/(\d+) (\d+)/)
    obj = match[1]
Severity: Minor
Found in lib/msf/core/exploit/pdf_parse.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method xref_create has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def xref_create(stream,offset,num_obj)


    xref = Array.new()
    object = String.new()
Severity: Minor
Found in lib/msf/core/exploit/pdf_parse.rb - About 1 hr to fix

    Method object_locate has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def object_locate(xref_trailer,obj_name)

    found = false
    match = obj_name.match(/(\d+) (\d+)/)
    obj = match[1]
    Severity: Minor
    Found in lib/msf/core/exploit/pdf_parse.rb - About 1 hr to fix

      Method parse_pdf has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def parse_pdf(stream)

    xref_array = Array.new()

    startxrefs = Array.new()
      Severity: Minor
      Found in lib/msf/core/exploit/pdf_parse.rb - About 1 hr to fix

        Method parse_pdf has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def parse_pdf(stream)

    xref_array = Array.new()

    startxrefs = Array.new()
        Severity: Minor
        Found in lib/msf/core/exploit/pdf_parse.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method trailer_parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def trailer_parse(xref_trailer)
    trailer = Hash.new()

    if match = xref_trailer.match(/Size (\d+)/m)
      trailer['Size'] = match[1]
        Severity: Minor
        Found in lib/msf/core/exploit/pdf_parse.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parse_object has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def parse_object(xref_trailers,obj_name,stream)

    for xrefs in xref_trailers
      offset = object_locate(xrefs,obj_name)
      if offset
        Severity: Minor
        Found in lib/msf/core/exploit/pdf_parse.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status