Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/exploit/php_exe.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method get_write_exec_payload has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def get_write_exec_payload(opts={})
    case target_arch.first
    when ARCH_PHP
      php = payload.encoded
    else
Severity: Minor
Found in lib/msf/core/exploit/php_exe.rb - About 1 hr to fix

    Method get_write_exec_payload has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def get_write_exec_payload(opts={})
    case target_arch.first
    when ARCH_PHP
      php = payload.encoded
    else
    Severity: Minor
    Found in lib/msf/core/exploit/php_exe.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status